Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run webhooks as part of the main manager #3822

Closed
vincepri opened this issue Oct 19, 2020 · 4 comments · Fixed by #3985
Closed

Run webhooks as part of the main manager #3822

vincepri opened this issue Oct 19, 2020 · 4 comments · Fixed by #3985
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone

Comments

@vincepri
Copy link
Member

User Story

Given that #3042 for v1alpha4 requires single controllers managing all namespaces, we should move the webhooks back in the main manager and run them behind RBAC in case we'll need a client in the future.

Anything else you would like to add:

@fabriziopandini @wfernandes Clusterctl upgrade and operator needs to perform this migration as part of the upgrade path from v1alpha3.

/kind feature
/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Oct 19, 2020
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 19, 2020
@fabriziopandini
Copy link
Member

That's a huge simplification, yay!

@wfernandes
Copy link
Contributor

I'll make a note of it somewhere in the CAEP. Thanks. And yes, definitely a huge simplification!

@wfernandes
Copy link
Contributor

Just adding for future reference. This issue is referenced in the management cluster operator caep under the Upgrade from v1alpha3 management cluster to v1alpha4 cluster section.

@fabriziopandini
Copy link
Member

I'm starting to work on this issue, with the goal to start clarifying impacts on clusterctl init and clusterctl upgrades
/assign
/lifecycle active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants