You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
v1alpha7 OpenStackMachine conversion should ignore changes to ProviderID and InstanceID and run the restorers even if they have changed. This is because these spec fields are modified by the openstack machine controller, so if we didn't exclude them, v1alpha7 users would always see changes to user-managed fields in the machine spec after conversion.
There's a test for this, TestMachineConversionControllerSpecFields, but it's broken in v1alpha7 and doesn't actually check that a lossy field was correctly restored.
The text was updated successfully, but these errors were encountered:
/kind bug
v1alpha7 OpenStackMachine conversion should ignore changes to ProviderID and InstanceID and run the restorers even if they have changed. This is because these spec fields are modified by the openstack machine controller, so if we didn't exclude them, v1alpha7 users would always see changes to user-managed fields in the machine spec after conversion.
There's a test for this,
TestMachineConversionControllerSpecFields
, but it's broken in v1alpha7 and doesn't actually check that a lossy field was correctly restored.The text was updated successfully, but these errors were encountered: