Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1alpha7 Machine conversion is lossy when controller sets ProviderID or InstanceID #1986

Closed
mdbooth opened this issue Apr 1, 2024 · 0 comments · Fixed by #1987
Closed

v1alpha7 Machine conversion is lossy when controller sets ProviderID or InstanceID #1986

mdbooth opened this issue Apr 1, 2024 · 0 comments · Fixed by #1987
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Apr 1, 2024

/kind bug

v1alpha7 OpenStackMachine conversion should ignore changes to ProviderID and InstanceID and run the restorers even if they have changed. This is because these spec fields are modified by the openstack machine controller, so if we didn't exclude them, v1alpha7 users would always see changes to user-managed fields in the machine spec after conversion.

There's a test for this, TestMachineConversionControllerSpecFields, but it's broken in v1alpha7 and doesn't actually check that a lossy field was correctly restored.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 1, 2024
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants