OpenStackMachineSpec.ServerMetadata should not be a map

[mdbooth]

/kind feature

OpenStackMachineSpec.ServerMetadata should not be a map. To comply with k8s API conventions it should be a list of name/value pairs with listType=map.

[EmilienM]

@mdbooth I was about to look at this one but I have a doubt. Should we still try to improve the API here, while in Gophercloud this is exposed as Metadata map[string]string ?

[mdbooth]

How would you improve it?

This is a breaking chance, btw, so it depends on another version bump. We're going to have to do that eventually, and before long, but we may not want to do it immediately.

[EmilienM]

How would you improve it?

By doing the Key Value thing, like we know of.
But my question was more on the fact that the Gophercloud interface is a map[string]string, and I wonder if I should changed that too for consistency or if we're fine with a convert here.

This is a breaking chance, btw, so it depends on another version bump. We're going to have to do that eventually, and before long, but we may not want to do it immediately.

I know and that's why I started to look at this one :-)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[EmilienM]

/remove-lifecycle stale
this is getting merged