-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support autoscaling from zero #3679
Comments
/triage accepted I saw this and wanted to do it! :) |
/assign Skarlso |
Ping @richardcase, @sedefsavas and @Ankitasw for a second opinion. :) |
Also, now I'm wondering, when and how do we usually do triage-es? |
My understanding from reading this is as follows:
I'm not sure what else is required. Do we just have to add the annotations based on our spec fields and reconcile them back into the status field? Is that it? :) ( ignoring validations and the likes for now ). Maybe reconciling it back into the spec if the annotations exist, might disrupt some flow. Like, it would cause a diff since local resources don't contain those settings. Found in the Code: // The annotations should override any values from the status block of the machine template.
// We loop through the status block capacity first, then overwrite any values with the
// annotation capacities. So status IS something the autoscaler will pick up. |
And preventing CAPA itself from creating a machine instance where it expects one to be if these fields are defined. |
Aha infraref, found, err := unstructured.NestedStringMap(r.unstructured.Object, "spec", "template", "spec", "infrastructureRef") |
Answer from cluster-api channel: Yes, it's enough to define the status. |
/kind feature
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Add support for autoscaling from zero defined in https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20210310-opt-in-autoscaling-from-zero.md
Just implemented upstream in kubernetes/autoscaler#4840
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:
kubectl version
):/etc/os-release
):The text was updated successfully, but these errors were encountered: