Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPA should not use ObjectMeta.ClusterName #3321

Closed
pydctw opened this issue Mar 16, 2022 · 2 comments · Fixed by #3322
Closed

CAPA should not use ObjectMeta.ClusterName #3321

pydctw opened this issue Mar 16, 2022 · 2 comments · Fixed by #3322
Assignees
@pydctw
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pydctw
Copy link
Contributor

pydctw commented Mar 16, 2022 •
edited
Loading

There is an upstream discussion about dropping ObjectMeta.ClusterName: kubernetes/kubernetes#108717. Related CAPI issue: kubernetes-sigs/cluster-api#6305

This field is not populated by Kubernetes and we should not use it as an CAPA Cluster Name.

This issue is about doing some research where we use it in CAPA and fix it if it is used.

/kind bug
@pydctw
Copy link
Contributor Author

pydctw commented Mar 16, 2022

/assign

@dims dims mentioned this issue Mar 16, 2022
Merged
@k8s-ci-robot
Copy link
Contributor

@pydctw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 16, 2022
@sedefsavas sedefsavas added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Mar 16, 2022
@sedefsavas sedefsavas added this to the v1.4.0 milestone Mar 16, 2022
@pydctw pydctw mentioned this issue Mar 16, 2022
Merged
4 tasks
@shysank shysank mentioned this issue Mar 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pydctw pydctw

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove .metadata.clusterName usage pydctw/cluster-api-provider-aws
3 participants
@k8s-ci-robot @pydctw @sedefsavas