-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chart parameter for install-blobfuse-proxy ability to disable setReadAheadSize #1717
feat: add chart parameter for install-blobfuse-proxy ability to disable setReadAheadSize #1717
Conversation
Welcome @mweibel! |
Hi @mweibel. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
latest chart config has changed, pls run "helm package charts/latest/blob-csi-driver -d charts/latest/" to update tgz file |
…le setReadAheadSize
168d92a
to
d5110df
Compare
@andyzhangx done! thanks. Is there anything else I need to do/run to make this change mergeable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, mweibel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Ability to disable setting read ahead size when installing blobfuse proxy in the init container. I'm testing blobfuse locally in a kind cluster and udev is disabled there by default.
Requirements:
Special notes for your reviewer:
Release note: