Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2] chore: add pre-commit and pre-push validation #1487

Merged
merged 5 commits into from
Aug 25, 2022
Merged

[V2] chore: add pre-commit and pre-push validation #1487

merged 5 commits into from
Aug 25, 2022

Conversation

edreed
Copy link
Collaborator

@edreed edreed commented Aug 25, 2022 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds pre-commit and pre-push validation of changes. Requires the installation of pre-commit hooks as documented in csi-dev.md

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2022
@k8s-ci-robot k8s-ci-robot requested a review from ZeroMagic August 25, 2022 04:14
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@edreed edreed removed the request for review from ZeroMagic August 25, 2022 04:17
@edreed
Copy link
Collaborator Author

edreed commented Aug 25, 2022

/cc @jmclong

@k8s-ci-robot
Copy link
Contributor

@edreed: GitHub didn't allow me to request PR reviews from the following users: jmclong.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jmclong

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@edreed edreed changed the title chore: add pre-commit and pre-push validation [V2] chore: add pre-commit and pre-push validation Aug 25, 2022
@nearora-msft
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed, nearora-msft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [edreed,nearora-msft]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edreed
Copy link
Collaborator Author

edreed commented Aug 25, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7747461 into kubernetes-sigs:main_v2 Aug 25, 2022
@edreed edreed deleted the edreed-pre-commit-hooks branch September 21, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landreasyan landreasyan Awaiting requested review from landreasyan

@nearora-msft nearora-msft Awaiting requested review from nearora-msft

Assignees

@nearora-msft nearora-msft

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edreed @k8s-ci-robot @nearora-msft