Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template files from docs/ to root #792

Merged

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Dec 27, 2018

Ref: kubernetes/steering#28 and kubernetes/community#3053

The template files need to be at the root of the repo. The content is as per https://github.com/kubernetes/kubernetes-template-project.

/assign @andrewtandoc @bigkraig @M00nF1sh

@k8s-ci-robot
Copy link
Contributor

@nikhita: GitHub didn't allow me to assign the following users: andrewtandoc.

Note that only kubernetes-sigs members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

Ref: kubernetes/steering#28

The template files need to be at the root of the repo. The content is as per https://github.com/kubernetes/kubernetes-template-project.

/assign @andrewtandoc @bigkraig @M00nF1sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2018
@nikhita
Copy link
Member Author

nikhita commented Dec 27, 2018

@andrewtandoc you are listed as an approver for this repo. You can get lgtm + approve powers if you apply for a kubernetes-sigs member. :)

Instructions for it are here:

@nikhita
Copy link
Member Author

nikhita commented Dec 27, 2018

Also, I'm not sure why the lint test fails here. Any suggestions?

@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Jan 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2019
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Jan 1, 2019

i'll fix the lint, looks like prow changed golang version

@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Jan 2, 2019

/re-test

@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Jan 2, 2019

/retest

@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Jan 2, 2019

thanks so much for changing this :D

/lgtm

@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Jan 2, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2019
@nikhita
Copy link
Member Author

nikhita commented Jan 2, 2019

@M00nF1sh Thanks for fixing the lint :)

@k8s-ci-robot k8s-ci-robot merged commit 670b356 into kubernetes-sigs:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants