-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable ingress instance e2e test for ipv6 #3416
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3416 +/- ##
=======================================
Coverage 55.76% 55.76%
=======================================
Files 149 149
Lines 8827 8827
=======================================
Hits 4922 4922
Misses 3571 3571
Partials 334 334 ☔ View full report in Codecov by Sentry. |
2dcbb68
to
3930944
Compare
3930944
to
30bdf8e
Compare
It might be useful to test dualstack load balancers on IPv4 clusters, but that's orthogonal. /lgtm |
/assign @M00nF1sh |
One wrinkle with IPv6 instance targets is that the instances must have a primary IPv6 address or the targets won't register. Primary IPv6 addresses are a relatively newish concept, so not all tools support them yet. For example, the Terraform AWS provider doesn't support it yet: hashicorp/terraform-provider-aws#33733 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh, oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* enable ingress instance e2e test for ipv6 * add coverage for ingress instance e2e test
Issue
Description
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯