Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ingress instance e2e test for ipv6 #3416

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

oliviassss
Copy link
Collaborator

@oliviassss oliviassss commented Oct 3, 2023

Issue

Description

  1. Enable ingress e2e test suites for instance ipv6 target type
  2. Update prow script to run ingress and service instance test suites for ipv6 clusters

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (eacb0c3) 55.76% compared to head (30bdf8e) 55.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3416   +/-   ##
=======================================
  Coverage   55.76%   55.76%           
=======================================
  Files         149      149           
  Lines        8827     8827           
=======================================
  Hits         4922     4922           
  Misses       3571     3571           
  Partials      334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2023
@oliviassss oliviassss added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 3, 2023
@oliviassss oliviassss force-pushed the alb-e2e-update branch 2 times, most recently from 2dcbb68 to 3930944 Compare October 3, 2023 17:07
@johngmyers
Copy link
Contributor

It might be useful to test dualstack load balancers on IPv4 clusters, but that's orthogonal.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2023
@johngmyers
Copy link
Contributor

/assign @M00nF1sh

@johngmyers
Copy link
Contributor

One wrinkle with IPv6 instance targets is that the instances must have a primary IPv6 address or the targets won't register. Primary IPv6 addresses are a relatively newish concept, so not all tools support them yet. For example, the Terraform AWS provider doesn't support it yet: hashicorp/terraform-provider-aws#33733

@M00nF1sh
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6ecfc62 into kubernetes-sigs:main Oct 27, 2023
6 checks passed
johngmyers pushed a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Feb 6, 2024
* enable ingress instance e2e test for ipv6

* add coverage for ingress instance e2e test
@oliviassss oliviassss deleted the alb-e2e-update branch May 15, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants