Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepTLSSecret should be true by default #2473

Closed
matti opened this issue Jan 23, 2022 · 1 comment · Fixed by #2483
Closed

keepTLSSecret should be true by default #2473

matti opened this issue Jan 23, 2022 · 1 comment · Fixed by #2483
Assignees
@kishorj
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@matti
Copy link

matti commented Jan 23, 2022 •
edited
Loading

running helm upgrade twice without keepTLSSecret: true results in

"error":"Internal error occurred: failed calling webhook "mtargetgroupbinding.elbv2.k8s.aws": Post "https://aws-load-balancer-webhook-service.aws-load-balancer-controller-1.svc:443/mutate-elbv2-k8s-aws-v1beta1-targetgroupbinding?timeout=10s\": x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "aws-load-balancer-controller-ca")"}

found this from #2071 (comment)
@kishorj
Copy link
Collaborator

kishorj commented Jan 26, 2022

/kind feature
we will consider it for future chart releases

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 26, 2022
@kishorj kishorj mentioned this issue Jan 28, 2022
Merged
6 tasks
@kishorj kishorj self-assigned this Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kishorj kishorj

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make keepTLSSecret true by default kishorj/aws-load-balancer-controller
3 participants
@matti @kishorj @k8s-ci-robot