The spec for Ingress resource is incorrect

[tlliddle]

The manifest for apiVersion: networking.k8s.io/v1 has the incorrect specs.

aws-load-balancer-controller/docs/examples/2048/2048_full.yaml

Lines 52 to 59 in 3a6ba6a

	spec:
	rules:
	- http:
	paths:
	- path: /*
	backend:
	serviceName: service-2048
	servicePort: 80

The spec should conform to the spec referenced here:
https://kubernetes.io/docs/concepts/services-networking/ingress/#the-ingress-resource

spec:
  rules:
    - http:
        paths:
        - path: /*
          pathType: Prefix
          backend:
             service:
               name:  service-2048
               port:
                 number: 80

[kishorj]

In v2.2.0, If pathType is not specified, it will default to ImplementationSpecific. The spec you provided will fail validation since pathType: Prefix will not allow wildcards ? or *.

Did you encounter any issues with the provided manifest?

[tlliddle]

@kishorj - You are correct. Copy/Paste error from my last test. This is the error you are referring too?

{"level":"error","ts":1623347854.85268,"logger":"controller","msg":"Reconciler error","controller":"ingress","name":"ingress-2048","namespace":"game-2048","error":"ingress: game-2048/ingress-2048: prefix path shouldn't contain wildcards: /*"}

I did have to specify a pathType because I received this error when I didn't.

The Ingress "ingress-2048" is invalid: spec.rules[0].http.paths[0].pathType: Required value: pathType must be specified

This is the correct spec that tested successfully.

spec:
  rules:
    - http:
        paths:
        - path: /
          pathType: Prefix
          backend:
             service:
               name:  service-2048
               port:
                 number: 80

[M00nF1sh]

i think we should revert this PR: #2040

networking/v1 is not supported in 1.16 yet, but this file needs to support all supported eks versions as it's used in docs.
also, the backend schema changed in networking/v1 and it's incorrect.

[ns0092]

@M00nF1sh To confirm, what is the fix for this?
If I have the path as /, I get 404 for /foo as the Ingress does not treat / as /*.

Having path /* seems to solve the routing problem but I see the error on aws-alb-controller logs:

{"level":"error","ts":1627597396.9217522,"logger":"controller","msg":"Reconciler error","controller":"ingress","name":"sample-ingress","namespace":"default","error":"ingress: default/sample-ingress: prefix path shouldn't contain wildcards: /*"

[fert-f]

Had the same problem. Seems that changing pathType will allow wildcards in hosts:
path: /* pathType: ImplementationSpecific

[sergioteixeirabasecone]

Hi, someone could solve the issue with /* ?

[goddini91]

no

[insideClaw]

Had the same problem. Seems that changing pathType will allow wildcards in hosts: path: /* pathType: ImplementationSpecific

This works well and made my prefix path shouldn't contain wildcards: /* error go away, but I went with changing the pathType to just / (as tlliddle suggested earlier).

As is listed in the Ingress Examples, this is the correct pattern for "match everything". Only problem is that it's a breaking change that requires the new aws controller version already.