-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve csi-snapshotter ClusterRole #491
Improve csi-snapshotter ClusterRole #491
Conversation
Signed-off-by: ialidzhikov <[email protected]>
Hi @ialidzhikov. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 1087
💛 - Coveralls |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov, leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
/kind cleanup
What is this PR about? / Why do we need it?
With v2.0.0 of kubernetes-csi/external-snapshotter, it is split into two component - the csi-snapshotter sidecar and the snapshot controller (ref kubernetes-csi/external-snapshotter#182). As the
VolumeSnapshot
watch is moved to the new snapshot controller, the csi-snapshotter sidecar ClusterRole no longer needs rules for volumesnapshots.This PR adapts the csi-snapshotter sidecar RBAC according to https://github.com/kubernetes-csi/external-snapshotter/blob/v2.1.1/deploy/kubernetes/csi-snapshotter/rbac-csi-snapshotter.yaml.
What testing is done?