Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure kustomize does not get updated until after image is available in all registries. #994

Closed
wongma7 opened this issue Jul 26, 2021 · 1 comment · Fixed by #995
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@wongma7
Copy link
Contributor

wongma7 commented Jul 26, 2021

/kind bug

What happened? For 1.1.3, (and to lesser extent all other bugfix releases), the kustomize template was updated before the image was actually in GCR.

Update the release process so that the kustomize template PR gets merged AFTER the image builds succeed https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/RELEASE.md.

The same problem used to exist for helm and we already fixed that by changing the process so that maintainers merge the master branch change and trigger a helm chart release AFTER the image build succeed, basically we need to also do the same for our kustomize users.

/assign

CC #993

What you expected to happen?

How to reproduce it (as minimally and precisely as possible)?

Anything else we need to know?:

Environment

  • Kubernetes version (use kubectl version):
  • Driver version:
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 26, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Jul 26, 2021

BTW, I think it's an oversight because for a minor version 1.y.0 release, of course you are creating the release-1.y branch for the first time, so there is no harm in merging the kustomize template before changing the master branch kustomize command to point to the release-1.y branch.

But for a patch 1.y.x release, the master branch kustomize command already points to the release-1.y branch so we really ahve to be careful not to modify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
2 participants