Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking changes for v2.0.0 of the helm chart #964

Closed
krmichel opened this issue Jul 2, 2021 · 2 comments · Fixed by #965
Closed

Breaking changes for v2.0.0 of the helm chart #964

krmichel opened this issue Jul 2, 2021 · 2 comments · Fixed by #965
Assignees
@krmichel

Comments

@krmichel
Copy link
Contributor

krmichel commented Jul 2, 2021 •
edited
Loading

/kind feature

Describe the solution you'd like in detail
There are deprecated values in the helm chart. They should be removed in the next major release of the chart.
The helm chart still supports helm v2 which was end of lifed in November 2020. The next major release should require helm v3 or above.

Additional context
PR #856 deprecated the fields in favor of a more clear organization of values.
@krmichel
Copy link
Contributor Author

krmichel commented Jul 3, 2021

@wongma7 Do you want me to take a stab at removing the snapshot controller installation along with the other breaking changes I am making? I might need some advice on how the documentation for it being a prerequisite should be worded.

@krmichel
Copy link
Contributor Author

krmichel commented Jul 5, 2021

/assign

@krmichel krmichel mentioned this issue Jul 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krmichel krmichel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Several breaking changes to the helm chart krmichel/aws-ebs-csi-driver
1 participant
@krmichel