Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NodePublish mount idempotent #955

Closed
3 of 4 tasks
wongma7 opened this issue Jun 24, 2021 · 0 comments · Fixed by #1019
Closed
3 of 4 tasks

Make NodePublish mount idempotent #955

wongma7 opened this issue Jun 24, 2021 · 0 comments · Fixed by #1019
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@wongma7
Copy link
Contributor

wongma7 commented Jun 24, 2021

/kind bug

What happened? as of kubernetes 1.20, kubelet doesn't check if the target path exists or is mounted for us kubernetes/kubernetes#88759 . path existence should be idempotent i.e. if path already exists, NodeStage/NodePublish should not error. mount should be idempotent i.e. if the thing that's supposed to be mounted at the path is already there then NodeStage/NodePublish should not error

NodeStage:

NodePublish*:

What you expected to happen?

How to reproduce it (as minimally and precisely as possible)?

Anything else we need to know?:

Environment

  • Kubernetes version (use kubectl version):
  • Driver version:
@wongma7 wongma7 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jun 24, 2021
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants