Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NewMetadataService + add instance metadata documentation #898

Closed
wongma7 opened this issue May 21, 2021 · 0 comments
Closed

Refactor NewMetadataService + add instance metadata documentation #898

wongma7 opened this issue May 21, 2021 · 0 comments
Assignees
@wongma7
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@wongma7
Copy link
Contributor

wongma7 commented May 21, 2021

What happened? #897 enables us to refactor the metadata code to be simpler , to be 100% clear that the driver will retrieve NodeGetInfo info from EITHER ec2 metadata OR k8s client. This will also let us simplify the unit tests and write a new unit test that, if metadata is enabled, do not try to create a k8s client.

What you expected to happen?

How to reproduce it (as minimally and precisely as possible)?

Anything else we need to know?:

Environment

  • Kubernetes version (use kubectl version):
  • Driver version:
@wongma7 wongma7 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 21, 2021
@wongma7 wongma7 self-assigned this May 21, 2021
@wongma7 wongma7 closed this as completed Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wongma7 wongma7

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wongma7