Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControllerUnpublish should return no error on success. #330

Closed
jsafrane opened this issue Aug 7, 2019 · 2 comments · Fixed by #375
Closed

ControllerUnpublish should return no error on success. #330

jsafrane opened this issue Aug 7, 2019 · 2 comments · Fixed by #375
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
0.5

Comments

@jsafrane
Copy link
Contributor

jsafrane commented Aug 7, 2019

/kind bug

What happened?
The driver returns codes.Internal when detaching a volume from deleted node or detaching a deleted volume (deleted outside of the CSI driver). As AWS detaches volumes when a node is deleted and deleted volume must have been detached before, returning success is more appropriate.

When codes.Internal is returned, CO will retry again, introducing endless loop between CO and the driver.

See container-storage-interface/spec#373 for discussion.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 7, 2019
@jsafrane jsafrane mentioned this issue Aug 7, 2019
Merged
@leakingtapan leakingtapan added this to the 0.5 milestone Aug 7, 2019
@bertinatto bertinatto mentioned this issue Sep 16, 2019
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2019
@leakingtapan
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2019
@jsafrane jsafrane mentioned this issue Nov 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Return success if instance or volume are not found bertinatto/aws-ebs-csi-driver
4 participants
@jsafrane @leakingtapan @k8s-ci-robot @fejta-bot