Kustomize fails to patch controller Deployment

[mvgmb]

/kind bug

What happened?

When applying multiple patches to the deploy manifests via Kustomize (v5.0.3+), it fails to build with the following error:

$ kustomize build ./deploy/kubernetes/overlays/stable 
Error: updating name reference in 'spec/template/spec/containers/envFrom/configMapRef/name' field of 'Deployment.v1.apps/ebs-csi-controller.kube-system': considering field 'spec/template/spec/containers/envFrom/configMapRef/name' of object Deployment.v1.apps/ebs-csi-controller.kube-system: visit traversal on path: [envFrom configMapRef name]: expected sequence or mapping node

It expects the spec/template/spec/containers/envFrom field to be a sequence or mapping node, however, it's null.

aws-ebs-csi-driver/deploy/kubernetes/base/controller.yaml

Line 97 in ed3c33d

envFrom:

What you expected to happen?

I expected both patches to be applied.

How to reproduce it (as minimally and precisely as possible)?

Add the following patches to the deploy/kubernetes/overlays/stable/kustomization.yaml:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
  - ./ecr-public
patches:
  - patch: '[{"op": "add","path": "/spec/template/spec/containers/0/args/-","value": "--http-endpoint=:8080"}]'
    target:
      group: apps
      version: v1
      kind: Deployment
      name: ebs-csi-controller
  - patch: |-
      apiVersion: apps/v1
      kind: Deployment
      metadata:
        namespace: kube-system
        name: ebs-csi-controller
      spec:
        template:
          metadata:
            annotations:
              prometheus.io/port: '8080'
              prometheus.io/scrape: 'true'

Then run:

kustomize build ./deploy/kubernetes/overlays/stable 

Anything else we need to know?

This problem can be solved by avoiding generating empty envFrom fields from the Helm charts.

aws-ebs-csi-driver/deploy/kubernetes/base/controller.yaml

Line 97 in ed3c33d

envFrom:

Environment

• Kubernetes version (use kubectl version): N/A
• kustomize version: v5.0.3
• Driver version: v1.19.0