Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: copy from non-storage version instead of storage version #97

Merged
merged 1 commit into from
Oct 17, 2023
Merged

bugfix: copy from non-storage version instead of storage version #97

merged 1 commit into from
Oct 17, 2023

Conversation

JackyZhangFuDan
Copy link
Contributor

@JackyZhangFuDan JackyZhangFuDan commented Oct 17, 2023 •
edited
Loading

In that duty line (43), parameter 'from' is 'storageVersionObj' which is storage version object reference, it needn't to implement interface MultiVersionObject, so it can't be convert to that interface anyway.

It looks like line 43 contains a bug: 'from' and 'to' should be switched positions. Kindly review and confirm, thanks.

BTW, I use the fix to replace the official library locally to run my aggregated server, success. So most likely it is a bug.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 17, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: JackyZhangFuDan (3277a16)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @JackyZhangFuDan!

It looks like this is your first PR to kubernetes-sigs/apiserver-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/apiserver-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 17, 2023
@JackyZhangFuDan
Copy link
Contributor Author

@pwittrock
@yue9944882

Could you please review? thanks

@pwittrock
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JackyZhangFuDan, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4d54d00 into kubernetes-sigs:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabbifish gabbifish Awaiting requested review from gabbifish

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackyZhangFuDan @k8s-ci-robot @pwittrock