From 7d4a49f0c3bd4b0ef1a1d3417c0fbc516612c4e5 Mon Sep 17 00:00:00 2001 From: Jun Gong Date: Tue, 2 Apr 2019 14:29:42 +0800 Subject: [PATCH] Add test for LoadSchedulerConf --- pkg/scheduler/util_test.go | 139 +++++++++++++++++++++++++++++++++++++ 1 file changed, 139 insertions(+) create mode 100644 pkg/scheduler/util_test.go diff --git a/pkg/scheduler/util_test.go b/pkg/scheduler/util_test.go new file mode 100644 index 000000000..8e06f7daa --- /dev/null +++ b/pkg/scheduler/util_test.go @@ -0,0 +1,139 @@ +/* +Copyright 2019 The Kubernetes Authors. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package scheduler + +import ( + "reflect" + "testing" + + _ "github.com/kubernetes-sigs/kube-batch/pkg/scheduler/actions" + "github.com/kubernetes-sigs/kube-batch/pkg/scheduler/conf" +) + +func TestLoadSchedulerConf(t *testing.T) { + configuration := ` +actions: "allocate, backfill" +tiers: +- plugins: + - name: priority + - name: gang + - name: conformance +- plugins: + - name: drf + - name: predicates + - name: proportion + - name: nodeorder +` + + trueValue := true + expectedTiers := []conf.Tier{ + { + Plugins: []conf.PluginOption{ + { + Name: "priority", + EnabledJobOrder: &trueValue, + EnabledJobReady: &trueValue, + EnabledTaskOrder: &trueValue, + EnabledPreemptable: &trueValue, + EnabledReclaimable: &trueValue, + EnabledQueueOrder: &trueValue, + EnabledPredicate: &trueValue, + EnabledNodeOrder: &trueValue, + }, + { + Name: "gang", + EnabledJobOrder: &trueValue, + EnabledJobReady: &trueValue, + EnabledTaskOrder: &trueValue, + EnabledPreemptable: &trueValue, + EnabledReclaimable: &trueValue, + EnabledQueueOrder: &trueValue, + EnabledPredicate: &trueValue, + EnabledNodeOrder: &trueValue, + }, + { + Name: "conformance", + EnabledJobOrder: &trueValue, + EnabledJobReady: &trueValue, + EnabledTaskOrder: &trueValue, + EnabledPreemptable: &trueValue, + EnabledReclaimable: &trueValue, + EnabledQueueOrder: &trueValue, + EnabledPredicate: &trueValue, + EnabledNodeOrder: &trueValue, + }, + }, + }, + { + Plugins: []conf.PluginOption{ + { + Name: "drf", + EnabledJobOrder: &trueValue, + EnabledJobReady: &trueValue, + EnabledTaskOrder: &trueValue, + EnabledPreemptable: &trueValue, + EnabledReclaimable: &trueValue, + EnabledQueueOrder: &trueValue, + EnabledPredicate: &trueValue, + EnabledNodeOrder: &trueValue, + }, + { + Name: "predicates", + EnabledJobOrder: &trueValue, + EnabledJobReady: &trueValue, + EnabledTaskOrder: &trueValue, + EnabledPreemptable: &trueValue, + EnabledReclaimable: &trueValue, + EnabledQueueOrder: &trueValue, + EnabledPredicate: &trueValue, + EnabledNodeOrder: &trueValue, + }, + { + Name: "proportion", + EnabledJobOrder: &trueValue, + EnabledJobReady: &trueValue, + EnabledTaskOrder: &trueValue, + EnabledPreemptable: &trueValue, + EnabledReclaimable: &trueValue, + EnabledQueueOrder: &trueValue, + EnabledPredicate: &trueValue, + EnabledNodeOrder: &trueValue, + }, + { + Name: "nodeorder", + EnabledJobOrder: &trueValue, + EnabledJobReady: &trueValue, + EnabledTaskOrder: &trueValue, + EnabledPreemptable: &trueValue, + EnabledReclaimable: &trueValue, + EnabledQueueOrder: &trueValue, + EnabledPredicate: &trueValue, + EnabledNodeOrder: &trueValue, + }, + }, + }, + } + + _, tiers, err := loadSchedulerConf(configuration) + if err != nil { + t.Errorf("Failed to load scheduler configuration: %v", err) + } + if !reflect.DeepEqual(tiers, expectedTiers) { + t.Errorf("Failed to set default settings for plugins, expected: %+v, got %+v", + expectedTiers, tiers) + } +}