This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Automatically creates the token auth file if it isn't present #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 40.75% 40.79% +0.04%
==========================================
Files 37 37
Lines 2660 2662 +2
==========================================
+ Hits 1084 1086 +2
Misses 1418 1418
Partials 158 158
Continue to review full report at Codecov.
|
mumoshu
reviewed
Mar 23, 2017
|
|
||
| // Auto-creates the auth token file, useful for those coming from previous versions of kube-aws | ||
| if _, err := os.Stat(authTokenPath); os.IsNotExist(err) { | ||
| os.OpenFile(authTokenPath, os.O_RDONLY|os.O_CREATE, 0600) |
There was a problem hiding this comment.
Almost nit but wouldn't it be safer to close the opened file afterwards?
There was a problem hiding this comment.
Argh, forgot to close it. 😓
@mumoshu just to let you know, feel free not to merge my PRs unless they are 100% according to your standards regarding code style, quality, and so on; just give me your feedback and I'll try to address them ASAP.
|
1 nit but LGTM overall 👍 |
|
Thanks! I just tend to merge a PR if it looks 90% ok so that contributors
won't suffer from potential conflicts and rebasing while making a tiny fix.
Of course there's no problem for me to adjust to you.
2017年3月23日(木) 22:12 Daniel Martins <[email protected]>:
… ***@***.**** commented on this pull request.
------------------------------
In core/controlplane/config/token_config.go
<#439 (comment)>
:
> @@ -152,6 +153,12 @@ func (r *EncryptedAuthTokensOnDisk) Compact() (*CompactAuthTokens, error) {
func ReadOrEncryptAuthTokens(dirname string, encryptor CachedEncryptor) (*EncryptedAuthTokensOnDisk, error) {
authTokenPath := filepath.Join(dirname, "tokens.csv")
+
+ // Auto-creates the auth token file, useful for those coming from previous versions of kube-aws
+ if _, err := os.Stat(authTokenPath); os.IsNotExist(err) {
+ os.OpenFile(authTokenPath, os.O_RDONLY|os.O_CREATE, 0600)
Argh, forgot to close it. 😓
@mumoshu <https://github.com/mumoshu> just to let you know, feel free not
to merge my PRs unless they are 100% according to your standards regarding
code style, quality, and so on; just give me your feedback and I'll try to
address them ASAP.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#439 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABV-UydaxSmodmykbxX2W6lww9_ySPGks5rom-2gaJpZM4Ml_kl>
.
|
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
…token-file Automatically creates the token auth file if it isn't present
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves UX after #418, hopefully avoiding issues like this.