Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

instructions to enable oldtimer API #1577

Closed
wants to merge 1 commit into from

Conversation

cainelli
Copy link

Hi there, I've added basic instructions on how to enable the old-timer API based on #1172. It took me some time to search on the repo. I think others may found useful to see this present on the proposal doc.

Thanks.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 17, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @cainelli. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-reviewable
Copy link

This change is Reviewable

@cainelli
Copy link
Author

I signed it!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 17, 2017
@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Mar 21, 2017

Oldtimer was never widely implemented, and is very likely going to be deprecated and removed over the next couple of releases. I'm not entirely certain it's worth providing these instructions (especially without a deprecation notice).

@piosz WDYT

@cainelli
Copy link
Author

So will the main endpoints extract metrics older than 15 min. or if we want to do that we'll have to query the backend sink?

@DirectXMan12
Copy link
Contributor

So will the main endpoints extract metrics older than 15 min. or if we want to do that we'll have to query the backend sink?

Eventually we'll have something along the same lines as the new custom metrics API -- a set of type definitions and API paths that will be implemented separately for each sink, except in a clearly historical context (as opposed to the custom metrics API, which is for recent metrics).

@@ -48,6 +48,8 @@ When used simply to retrieve historical data points, Oldtimer will return the
same types as the model API. When the used to retrieve aggregations, Oldtimer
will return special data types detailed under the "Return Types" section.

Oltimer API can be enabled by passing --historical_source with one of the URIs used in the --sink argument.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oldtimer was misspelled

@piosz
Copy link
Contributor

piosz commented Jun 21, 2017

#1577 (comment)
+1

@piosz piosz closed this Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants