Improve ES Sink: #1260
Improve ES Sink: #1260
Conversation
- support AWS authentication for ES servers - print errors if exists - change elastic library to the proper url(using v.3) - fixes ES Sink URI doesn't support single node config(only with ?nodes) - bring back the go-extpoint that was required by the doc
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
revert Makefile change [mistakenly commited]
|
@huangyuqi could you please take a look? |
|
@Thermi can you help us out here and do a code review also? |
| @@ -3,7 +3,8 @@ | |||
| "GoVersion": "go1.6", | |||
| "GodepVersion": "v74", | |||
| "Packages": [ | |||
| "./..." | |||
| "./...", | |||
| "github.com/progrium/go-extpoints" | |||
There was a problem hiding this comment.
Please remove progrium. We no longer use this, though the documentation is outdated.
|
Godeps/Godeps.json, line 7 [r2] (raw file):
|
|
@piosz I've fixed the issue you raised (and removed the go-ext dependency). @huangyuqi @Thermi did you had a chance to review it? |
|
@piosz @AlmogBaku yes, I'd be happy to review this PR. Thanks. |
| @@ -76,7 +78,7 @@ func CreateElasticSearchConfig(uri *url.URL) (*ElasticSearchConfig, error) { | |||
| var esConfig ElasticSearchConfig | |||
| opts, err := url.ParseQuery(uri.RawQuery) | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to parser url's query string: %s", err) | |||
| return nil, fmt.Errorf("fFailed to parser url's query string: %s", err) | |||
|
Thanks @huangyuqi for offering your help. |
|
common/elasticsearch/elasticsearch.go, line 81 [r1] (raw file):
|
|
Review status: 0 of 199 files reviewed at latest revision, 7 unresolved discussions. common/elasticsearch/elasticsearch.go, line 133 [r1] (raw file):
|
|
@AlmogBaku thanks for the contribution. |
gopkgnamespace for elasticsearch rather than the github(as specified in the library documentation)This change is