Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

ElasticSearch 6 support #1909

Closed
pschulten opened this issue Dec 11, 2017 · 15 comments
Closed

ElasticSearch 6 support #1909

pschulten opened this issue Dec 11, 2017 · 15 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sink/elasticsearch

Comments

@pschulten
Copy link

We're logging to ES 6 and the heapster export fails with:

W1211 13:30:19.368537 1 driver.go:75] Failed to export data to ElasticSearch sink: elastic: Error 400 (Bad Request): Failed to parse mapping [general]: No handler for type [string] declared on field [cluster_name] [type=mapper_parsing_exception]

@tstoermer
Copy link

ES 6 does no longer support multiple types in mappings per index. The metrics must be merged to one type or written to different indices.
https://www.elastic.co/guide/en/elasticsearch/reference/6.0/breaking-changes-6.0.html

There is also a new version of the used ES client
https://github.com/olivere/elastic

plaurin84 added a commit to plaurin84/elastic-curator that referenced this issue Dec 12, 2017
Downgrade elasticsearch from 6.0.1 to 5.6.5 for heapster sink compatiblity.
See kubernetes-retired/heapster#1909
@DirectXMan12
Copy link
Contributor

cc @AlmogBaku @huangyuqi @andyxning

@DirectXMan12 DirectXMan12 added sink/elasticsearch kind/feature Categorizes issue or PR as related to a new feature. labels Jan 4, 2018
@AlmogBaku
Copy link
Contributor

I'll try to find the time to make it supports ES6. If someone can pick it up please comment

@AlmogBaku
Copy link
Contributor

Guys we need to decide what the new schema should be for ES6 support. You're welcome to raise ideas here

@Adriien-M
Copy link

We are looking for this update, what is the status of this issue?

@f0
Copy link

f0 commented Mar 18, 2018

any progress to support elasticsearch 6?

@Freyert
Copy link

Freyert commented Mar 26, 2018

@AlmogBaku I'm postulating that these tests represent the original schema?

@tstoermer is this the documentation you were referencing?

Indices created here.
Sink Code is Here.

@tstoermer
Copy link

@Freyert
Right, just wanted to point the official breaking changes - linking to the details you mentioned.

@ihardzeenka
Copy link

Hi guys. About schema for ES 6.
Now you have single index with mapping types like cpu, memory, events and etc.
According to ES documentation there is 2 options here (https://www.elastic.co/guide/en/elasticsearch/reference/6.x/removal-of-types.html):

  1. Simply split single index into multiple indexes like: heapster-cpu , heapster-memory and etc.
  2. Merge types into single type (I don't really like that option)
    I don't know go language but looking into your code I believe it is not a big change to simply add existing type name into index name.

@MnrGreg
Copy link

MnrGreg commented Apr 8, 2018

Would be great to get something going here!

@jimk-osu
Copy link

jimk-osu commented Apr 17, 2018

+1

Would having a temporary countermeasure of single typing be OK with the goal of having a better solution as a permanent countermeasure?

I agree with @ihardzeenka that single typing may not be the right way, but it in the mean time a working solution would be best.

@DirectXMan12
Copy link
Contributor

Heapster is now deprecated, so we will no longer be adding new features or sinks. Please see https://github.com/kubernetes/heapster/blob/master/docs/deprecation.md#initial-deprecation-kubernetes-111 for more information. I apologize for any in progress sinks or features that will now no longer be merged.

@jhorwit2
Copy link

jhorwit2 commented Jun 4, 2018

@DirectXMan12 what's the deprecation plan for eventer since that's not included functionality in the metrics-server?

@smelchior
Copy link

we do currently have the same issue, maybe https://www.elastic.co/guide/en/beats/metricbeat/6.x/metricbeat-metricset-kubernetes-event.html can be used as an alternative?

@DirectXMan12
Copy link
Contributor

yeah, there's a few different solutions, depending on what your backend is. Someone could also try to adapt https://github.com/GoogleCloudPlatform/k8s-stackdriver/tree/master/event-exporter, or fork eventer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. sink/elasticsearch
Projects
None yet
Development

No branches or pull requests