Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

bump to 1.10.0 #954

Merged
merged 1 commit into from
Apr 6, 2018
Merged

bump to 1.10.0 #954

merged 1 commit into from
Apr 6, 2018

Conversation

rphillips
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2018
ericchiang
ericchiang approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rphillips
Copy link
Contributor Author

testing on AWS

@ericchiang
Copy link
Contributor

/hold

blocked on #957

@rphillips rphillips force-pushed the feat/bump_to_1.10 branch from 7fa0c24 to 804f682 Compare April 4, 2018 00:52
@dghubble
Copy link
Contributor

dghubble commented Apr 5, 2018

@rphillips there were a few apiserver flags you might consider tweaking. Not technically required, but they're mentioned in 1.10 deprecation notes. poseidon/terraform-render-bootstrap@5f3546b

@dghubble
Copy link
Contributor

dghubble commented Apr 5, 2018

Btw, admission control order doesn't matter now. I tried various orders and the apiserver logs mention the order its actually going to use. I chose to pass them in that same order so nobody gets worried.

@rphillips
Copy link
Contributor Author

@dghubble thanks, I'll get those in. Currently having an issue with 1.10 on AWS. The KubernetesCluster tag in this PR is required currently. I didn't notice a breaking change in the changelog.

@rphillips rphillips force-pushed the feat/bump_to_1.10 branch from 804f682 to 18eef94 Compare April 5, 2018 17:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 5, 2018
@rphillips rphillips force-pushed the feat/bump_to_1.10 branch from 18eef94 to ddb64f6 Compare April 5, 2018 17:47
@rphillips
Copy link
Contributor Author

rphillips commented Apr 5, 2018 •
edited
Loading

this PR is ready for another review... tags have been created correctly...

I still have a pending question with sig-aws if there is an upgrade path for old clusters.

ericchiang
ericchiang approved these changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref kubernetes/kubernetes#60125 (comment) for tag changes

lgtm

@rphillips rphillips force-pushed the feat/bump_to_1.10 branch 2 times, most recently from c00de9e to 079fdbe Compare April 5, 2018 19:48
@rphillips
Copy link
Contributor Author

using /proc/sys/kernel/random/uuid for the UUID, since uuidgen does not exist.

@rphillips rphillips force-pushed the feat/bump_to_1.10 branch from e7efe54 to 4636dd9 Compare April 5, 2018 20:38
@rphillips
Copy link
Contributor Author

coreosbot run e2e

@rphillips rphillips force-pushed the feat/bump_to_1.10 branch from 4636dd9 to 474e77c Compare April 5, 2018 22:29
ericchiang
ericchiang reviewed Apr 6, 2018
View reviewed changes
hack/jenkins/scripts/tqs-up.sh Outdated
@@ -27,12 +28,17 @@ set +x
export TF_VAR_access_key_id="${ACCESS_KEY_ID}"
export TF_VAR_access_key="${ACCESS_KEY_SECRET}"
set -x
export TF_VAR_kubernetes_id="$(cat /proc/sys/kernel/random/uuid)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also why can't this be done in terraform https://www.terraform.io/docs/providers/random/r/id.html ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented

ericchiang
ericchiang approved these changes Apr 6, 2018
View reviewed changes
Copy link
Contributor

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm

@rphillips rphillips force-pushed the feat/bump_to_1.10 branch from f0020ae to 27a6b97 Compare April 6, 2018 16:04
@rphillips rphillips merged commit 7bcecdc into kubernetes-retired:master Apr 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericchiang ericchiang ericchiang approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rphillips @ericchiang @dghubble @k8s-ci-robot