Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for v1.2 #127

Merged
merged 1 commit into from
Jun 19, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions CHANGELOG-1.2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Changelog since v1.1.0

## Breaking Changes

- Changes the API group name for the fake VolumeSnapshot object to "snapshot.storage.k8s.io" to be in-sync with the group name of the real VolumeSnapshot object. As a result, the generated interfaces for clientset and informers of VolumeSnapshot are also changed from "VolumeSnapshot" to "Snapshot". ([#123](https://github.com/kubernetes-csi/external-snapshotter/pull/123), [@xing-yang](https://github.com/xing-yang))
msau42 marked this conversation as resolved.
Show resolved Hide resolved

## New Features

- Adds Finalizer on the snapshot source PVC to prevent it from being deleted when a snapshot is being created from it. ([#47](https://github.com/kubernetes-csi/external-snapshotter/pull/47), [@xing-yang](https://github.com/xing-yang))

## Other Notable Changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you also want to mention the finalizer changes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Yes, added that. It was missed because the Finalizer PR was submitted longer time ago before we had the PR description template. The release notes tool only picks up the PRs with a release note.


- Add Status subresource for VolumeSnapshot. ([#121](https://github.com/kubernetes-csi/external-snapshotter/pull/121), [@zhucan](https://github.com/zhucan))