Skip to content

Latest commit

 

History

History
138 lines (101 loc) · 5.62 KB

README.md

File metadata and controls

138 lines (101 loc) · 5.62 KB
Raw

Scripts User Guide

This README documents:

  • What update-crd.sh and update-generated-code.sh do
  • When and how to use them
  • The CRD CEL rules test suite

update-generated-code.sh

This is the script to update clientset/informers/listers and API deepcopy code using code-generator.

Make sure to run this script after making changes to /client/apis/volumesnapshot/v1/types.go.

Pre-requisites for running update-generated-code.sh:

  • Set GOPATH

    export GOPATH=~/go

  • Ensure external-snapshotter repository is at ~/go/src/github.com/kubernetes-csi/external-snapshotter

  • Clone code-generator

    cd ~/go/src/k8s.io
git clone https://github.com/kubernetes/code-generator.git

  • Checkout latest release version

    git checkout v0.30.0

  • Ensure the file kube_codegen.sh exists

    ls ${GOPATH}/src/k8s.io/code-generator/kube_codegen.sh

Update generated client code in external-snapshotter

    cd ~/go/src/github.com/kubernetes-csi/external-snapshotter/client
    ./hack/update-generated-code.sh

Once you run the script, the code will be generated for volumesnapshot:v1 and volumegroupsnapshot:v1beta1, and you will get an output as follows:

Generating deepcopy code for 2 targets
Generating client code for 2 targets
Generating lister code for 2 targets
Generating informer code for 2 targets

update-crd.sh

NOTE: We need to keep both v1beta1 and v1 snapshot APIs but set served and storage version of v1beta1 to false. Please copy back the v1beta1 manifest back to the files as this script will remove it.

This is the script to update CRD yaml files under /client/config/crd/ based on types.go file.

Make sure to run this script after making changes to /client/apis.

Follow these steps to update the CRD:

  • Run ./hack/update-crd.sh from client directory, new yaml files should have been created under ./config/crd/

  • Add api-approved.kubernetes.io annotation value in all yaml files in the metadata section with the PR where the API is approved by the API reviewers. Refer to kubernetes/enhancements#1111 for details about this annotation.

  • Update the restoreSize property to string in snapshot.storage.k8s.io_volumesnapshots.yaml

The generated yaml file contains restoreSize property anyOf as described below:

            restoreSize:
              anyOf:
              - type: integer
              - type: string
              description: restoreSize represents the complete size of the snapshot
                in bytes. In dynamic snapshot creation case, this field will be filled
                in with the "size_bytes" value returned from CSI "CreateSnapshotRequest"
                gRPC call. For a pre-existing snapshot, this field will be filled
                with the "size_bytes" value returned from the CSI "ListSnapshots"
                gRPC call if the driver supports it. When restoring a volume from
                this snapshot, the size of the volume MUST NOT be smaller than the
                restoreSize if it is specified, otherwise the restoration will fail.
                If not specified, it indicates that the size is unknown.

Update the restoreSize property to use type string only:

   
            restoreSize:
              type: string
              description: restoreSize represents the complete size of the snapshot
                in bytes. In dynamic snapshot creation case, this field will be filled
                in with the "size_bytes" value returned from CSI "CreateSnapshotRequest"
                gRPC call. For a pre-existing snapshot, this field will be filled
                with the "size_bytes" value returned from the CSI "ListSnapshots"
                gRPC call if the driver supports it. When restoring a volume from
                this snapshot, the size of the volume MUST NOT be smaller than the
                restoreSize if it is specified, otherwise the restoration will fail.
                If not specified, it indicates that the size is unknown.

Test suite

The test-suite directory contains several test cases that are useful to validate if the CEL rules that are included in the CRD definitions are correctly working.

Prerequisites

  • Kubectl access to a cluster with the installed CRDs
  • Kubernetes >= 1.30

How to use it

  ./hack/run-cel-tests.sh

  cel-tests/volumegroupsnapshotcontent/vgsc-change-ref-namespace.post.yaml: SUCCESS
  cel-tests/volumegroupsnapshotcontent/vgsc-source-volume-to-groupsnapshot.post.yaml: SUCCESS
  cel-tests/volumegroupsnapshotcontent/vgsc-source-empty.yaml: SUCCESS (expected failure)
  cel-tests/volumegroupsnapshotcontent/vgsc-change-ref-namespace.pre.yaml: SUCCESS
  cel-tests/volumegroupsnapshotcontent/vgsc-ref-only-name.yaml: SUCCESS (expected failure)
  [...]
  cel-tests/volumegroupsnapshotcontent/vgsc-change-ref-namespace.pre.yaml -> cel-tests/volumegroupsnapshotcontent/vgsc-change-ref-namespace.post.yaml: SUCCESS (expected failure)
  cel-tests/volumegroupsnapshotcontent/vgsc-source-volume-immutable.pre.yaml -> cel-tests/volumegroupsnapshotcontent/vgsc-source-volume-immutable.post.yaml: SUCCESS (expected failure)
  cel-tests/volumegroupsnapshotcontent/vgsc-source-volume-to-groupsnapshot.pre.yaml -> cel-tests/volumegroupsnapshotcontent/vgsc-source-volume-to-groupsnapshot.post.yaml: SUCCESS (expected failure)
  cel-tests/volumegroupsnapshotcontent/vgsc-source-groupsnapshot-immutable.pre.yaml -> cel-tests/volumegroupsnapshotcontent/vgsc-source-groupsnapshot-immutable.post.yaml: SUCCESS (expected failure)
  [...]

  SUCCESS: 90
  FAILURES: 0