release-0.4: update release-tools #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubernetes-csi/csi-release-tools@7fe51491 Merge kubernetes-csi/csi-release-tools#200 from pohly/bump-kubernetes-version kubernetes-csi/csi-release-tools@70915a8e prow.sh: update snapshotter version kubernetes-csi/csi-release-tools@31a3f38b Merge kubernetes-csi/csi-release-tools#199 from pohly/bump-kubernetes-version kubernetes-csi/csi-release-tools@7577454a prow.sh: bump Kubernetes to v1.22.0 kubernetes-csi/csi-release-tools@d29a2e75 Merge kubernetes-csi/csi-release-tools#198 from pohly/csi-test-5.0.0 kubernetes-csi/csi-release-tools@41cb70d3 prow.sh: sanity testing with csi-test v5.0.0 kubernetes-csi/csi-release-tools@c85a63fb Merge kubernetes-csi/csi-release-tools#197 from pohly/fix-alpha-testing kubernetes-csi/csi-release-tools@b86d8e94 support Kubernetes 1.25 + Ginkgo v2 kubernetes-csi/csi-release-tools@ab0b0a3d Merge kubernetes-csi/csi-release-tools#192 from andyzhangx/patch-1 kubernetes-csi/csi-release-tools@7bbab24e Merge kubernetes-csi/csi-release-tools#196 from humblec/non-alpha kubernetes-csi/csi-release-tools@e51ff2cc introduce control variable for non alpha feature gate configuration kubernetes-csi/csi-release-tools@ca19ef52 Merge kubernetes-csi/csi-release-tools#195 from pohly/fix-alpha-testing kubernetes-csi/csi-release-tools@3948331e fix testing with latest Kubernetes kubernetes-csi/csi-release-tools@9a0260c5 fix boilerplate header git-subtree-dir: release-tools git-subtree-split: 7fe51491d8f56d0d459bf9abb9692bc9f96d2b75
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest Test failure should be fixed by #130 (:crossed_fingers: ). |
This was referenced Aug 5, 2022
There are multiple reasons why installing the external-health-monitor-controller cannot use the "normal" code: - the RBAC file is not where https://github.com/kubernetes-csi/csi-release-tools/blob/7fe51491d8f56d0d459bf9abb9692bc9f96d2b75/prow.sh#L1243-L1258 expects it - the variable for overriding the RBAC source in https://github.com/kubernetes-csi/csi-driver-host-path/blob/9be5dd74a7fc2436c4334820156056b74821998e/deploy/util/deploy-hostpath.sh#L157-L158 does not match the command name (csi-external-health-monitor-controller -> CSI_EXTERNAL_HEALTH_MONITOR_CONTROLLER_RBAC != CSI_EXTERNALHEALTH_MONITOR_RBAC_YAML) This solution was chosen because it can be done locally. Renaming the RBAC variable in csi-driver-host-path and moving files would have affected multiple repos and might not have been possible without some collateral damage. (cherry picked from commit 2976fe6)
k8s-ci-robot
removed
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed 'release-tools/' changes from e4dab7ff..7fe51491
7fe51491 Merge pull request #200 from pohly/bump-kubernetes-version
70915a8e prow.sh: update snapshotter version
31a3f38b Merge pull request #199 from pohly/bump-kubernetes-version
7577454a prow.sh: bump Kubernetes to v1.22.0
d29a2e75 Merge pull request #198 from pohly/csi-test-5.0.0
41cb70d3 prow.sh: sanity testing with csi-test v5.0.0
c85a63fb Merge pull request #197 from pohly/fix-alpha-testing
b86d8e94 support Kubernetes 1.25 + Ginkgo v2
ab0b0a3d Merge pull request #192 from andyzhangx/patch-1
7bbab24e Merge pull request #196 from humblec/non-alpha
e51ff2cc introduce control variable for non alpha feature gate configuration
ca19ef52 Merge pull request #195 from pohly/fix-alpha-testing
3948331e fix testing with latest Kubernetes
9a0260c5 fix boilerplate header
git-subtree-dir: release-tools
git-subtree-split: 7fe51491d8f56d0d459bf9abb9692bc9f96d2b75