Update sidecars with latest versions #407

msau42 · 2021-01-14T03:45:02Z

No description provided.

msau42 · 2021-01-14T03:45:42Z

book/src/external-snapshotter.md


 ### Description

-In the Beta version, the snapshot controller will be watching the Kubernetes API server for `VolumeSnapshot` and `VolumeSnapshotContent` CRD objects. The CSI `external-snapshotter` sidecar only watches the Kubernetes API server for `VolumeSnapshotContent` CRD objects. The CSI `external-snapshotter` sidecar is also responsible for calling the CSI RPCs CreateSnapshot, DeleteSnapshot, and ListSnapshots.
+Starting with the Beta version, the snapshot controller will be watching the Kubernetes API server for `VolumeSnapshot` and `VolumeSnapshotContent` CRD objects. The CSI `external-snapshotter` sidecar only watches the Kubernetes API server for `VolumeSnapshotContent` CRD objects. The CSI `external-snapshotter` sidecar is also responsible for calling the CSI RPCs CreateSnapshot, DeleteSnapshot, and ListSnapshots.

 For detailed snapshot beta design changes, see the design doc [here](https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/README.md).


I think the deployment part below needs to be updated for GA. @xing-yang can you take a look at that?

msau42 · 2021-01-14T03:46:02Z

/assign @xing-yang
/release-note-none

xing-yang · 2021-01-14T04:04:43Z

book/src/external-attacher.md

@@ -8,7 +8,7 @@

 Latest stable release | Branch | Min CSI Version | Max CSI Version | Container Image | [Min K8s Version](kubernetes-compatibility.md#minimum-version) | [Max K8s Version](kubernetes-compatibility.md#maximum-version) | [Recommended K8s Version](kubernetes-compatibility.md#recommended-version) |
 --|--|--|--|--|--|--|--
-[external-attacher v3.0.2](https://github.com/kubernetes-csi/external-attacher/releases/tag/v3.0.2) | [release-3.0](https://github.com/kubernetes-csi/external-attacher/tree/release-3.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/csi-attacher:v3.0.2 | v1.17 | - | v1.17


Why is 3.0 removed?

I replaced it because the min/max/recommended kubernetes versions are the same, so it is safe for vendors to skip over 3.0

I agree that we shouldn't list versions that are definitely replaced by something else.

OTOH, we do list also some historic versions that are no longer supported. Would it make sense to document explicitly which of the listed versions are still supported?

Yes, I could move them to a new table or add a new column. Or add a note that we officially only support the last X versions

I prefer a column. Less churn that maintaining a separate table and more obvious than letting everyone figure out what the last X versions are.

I've been thinking about this a little more, and I think it would be simpler to have a top level support policy page instead of having to update these all these tables every release. I prefer to work on that separately.

Okay, let's address that separately. Once there is a draft we'll see how easy it is to map that to specific sidecars.

xing-yang · 2021-01-14T04:06:31Z

book/src/external-snapshotter.md


 ### Description

-In the Beta version, the snapshot controller will be watching the Kubernetes API server for `VolumeSnapshot` and `VolumeSnapshotContent` CRD objects. The CSI `external-snapshotter` sidecar only watches the Kubernetes API server for `VolumeSnapshotContent` CRD objects. The CSI `external-snapshotter` sidecar is also responsible for calling the CSI RPCs CreateSnapshot, DeleteSnapshot, and ListSnapshots.
+Starting with the Beta version, the snapshot controller will be watching the Kubernetes API server for `VolumeSnapshot` and `VolumeSnapshotContent` CRD objects. The CSI `external-snapshotter` sidecar only watches the Kubernetes API server for `VolumeSnapshotContent` CRD objects. The CSI `external-snapshotter` sidecar is also responsible for calling the CSI RPCs CreateSnapshot, DeleteSnapshot, and ListSnapshots.

 For detailed snapshot beta design changes, see the design doc [here](https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/README.md).


xing-yang · 2021-01-14T04:07:10Z

book/src/external-provisioner.md

@@ -8,7 +8,7 @@

 Latest stable release | Branch | Min CSI Version | Max CSI Version | Container Image | [Min K8s Version](kubernetes-compatibility.md#minimum-version) | [Max K8s Version](kubernetes-compatibility.md#maximum-version) | [Recommended K8s Version](kubernetes-compatibility.md#recommended-version) |
 --|--|--|--|--|--|--|--
-[external-provisioner v2.0.4](https://github.com/kubernetes-csi/external-provisioner/releases/tag/v2.0.4) | [release-2.0](https://github.com/kubernetes-csi/external-provisioner/tree/release-2.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/csi-provisioner:v2.0.4 | v1.17 | - | v1.19
+[external-provisioner v2.1.0](https://github.com/kubernetes-csi/external-provisioner/releases/tag/v2.1.0) | [release-2.1](https://github.com/kubernetes-csi/external-provisioner/tree/release-2.1) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/csi-provisioner:v2.1.0 | v1.17 | - | v1.19


Why 2.0 is removed? We have kept 1.4, 1.5, 1.6 below.

xing-yang · 2021-01-14T04:07:34Z

book/src/external-resizer.md

@@ -8,7 +8,7 @@

 Latest stable release | Branch | Min CSI Version | Max CSI Version | Container Image | [Min K8s Version](kubernetes-compatibility.md#minimum-version) | [Max K8s Version](kubernetes-compatibility.md#maximum-version) | [Recommended K8s Version](kubernetes-compatibility.md#recommended-version) |
 --|--|--|--|--|--|--|--
-[external-resizer v1.0.1](https://github.com/kubernetes-csi/external-resizer/tree/v1.0.1)  | [release-1.0](https://github.com/kubernetes-csi/external-resizer/tree/release-1.0) |[v1.2.0](https://github.com/container-storage-interface/spec/releases/tag/v1.2.0) | - | k8s.gcr.io/sig-storage/csi-resizer:v1.0.1 | v1.16 | - | v1.16
+[external-resizer v1.1.0](https://github.com/kubernetes-csi/external-resizer/tree/v1.1.0)  | [release-1.1](https://github.com/kubernetes-csi/external-resizer/tree/release-1.1) |[v1.2.0](https://github.com/container-storage-interface/spec/releases/tag/v1.2.0) | - | k8s.gcr.io/sig-storage/csi-resizer:v1.1.0  | v1.16 | - | v1.16


Why is 1.0 removed?

xing-yang · 2021-02-01T20:27:37Z

book/src/external-provisioner.md

@@ -8,7 +8,7 @@

 Latest stable release | Branch | Min CSI Version | Max CSI Version | Container Image | [Min K8s Version](kubernetes-compatibility.md#minimum-version) | [Max K8s Version](kubernetes-compatibility.md#maximum-version) | [Recommended K8s Version](kubernetes-compatibility.md#recommended-version) |
 --|--|--|--|--|--|--|--
-[external-provisioner v2.0.4](https://github.com/kubernetes-csi/external-provisioner/releases/tag/v2.0.4) | [release-2.0](https://github.com/kubernetes-csi/external-provisioner/tree/release-2.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/csi-provisioner:v2.0.4 | v1.17 | - | v1.19
+[external-provisioner v2.1.0](https://github.com/kubernetes-csi/external-provisioner/releases/tag/v2.1.0) | [release-2.1](https://github.com/kubernetes-csi/external-provisioner/tree/release-2.1) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/csi-provisioner:v2.1.0 | v1.17 | - | v1.19
 [external-provisioner v1.6.0](https://github.com/kubernetes-csi/external-provisioner/releases/tag/v1.6.0) | [release-1.6](https://github.com/kubernetes-csi/external-provisioner/tree/release-1.6) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | quay.io/k8scsi/csi-provisioner:v1.6.0 | v1.13 | - | v1.18


This one should be updated to https://github.com/kubernetes-csi/external-provisioner/releases/tag/v1.6.1

xing-yang · 2021-02-01T20:32:16Z

book/src/external-snapshotter.md

-[external-snapshotter v1.2.2](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v1.2.2) | [release-1.2](https://github.com/kubernetes-csi/external-snapshotter/tree/release-1.2) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | quay.io/k8scsi/csi-snapshotter:v1.2.2 | v1.13 | v1.16 | v1.14
-[external-snapshotter v0.4.2](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v0.4.2) | [release-0.4](https://github.com/kubernetes-csi/external-snapshotter/tree/release-0.4) | [v0.3.0](https://github.com/container-storage-interface/spec/releases/tag/v0.3.0) | [v0.3.0](https://github.com/container-storage-interface/spec/releases/tag/v0.3.0) | quay.io/k8scsi/csi-snapshotter:v0.4.2 | v1.12 | v1.16 | v1.12
+[external-snapshotter v4.0.0](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v4.0.0) | [release-4.0](https://github.com/kubernetes-csi/external-snapshotter/tree/release-4.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/csi-snapshotter:v4.0.0, | v1.20 | - | v1.20
+[external-snapshotter v3.0.2 (beta)](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v3.0.2) | [release-3.0](https://github.com/kubernetes-csi/external-snapshotter/tree/release-3.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/csi-snapshotter:v3.0.2, | v1.17 | - | v1.17


https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v3.0.3

xing-yang · 2021-02-01T20:32:58Z

book/src/external-snapshotter.md

-[external-snapshotter v0.4.2](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v0.4.2) | [release-0.4](https://github.com/kubernetes-csi/external-snapshotter/tree/release-0.4) | [v0.3.0](https://github.com/container-storage-interface/spec/releases/tag/v0.3.0) | [v0.3.0](https://github.com/container-storage-interface/spec/releases/tag/v0.3.0) | quay.io/k8scsi/csi-snapshotter:v0.4.2 | v1.12 | v1.16 | v1.12
+[external-snapshotter v4.0.0](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v4.0.0) | [release-4.0](https://github.com/kubernetes-csi/external-snapshotter/tree/release-4.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/csi-snapshotter:v4.0.0, | v1.20 | - | v1.20
+[external-snapshotter v3.0.2 (beta)](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v3.0.2) | [release-3.0](https://github.com/kubernetes-csi/external-snapshotter/tree/release-3.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/csi-snapshotter:v3.0.2, | v1.17 | - | v1.17
+[external-snapshotter v2.1.0 (beta)](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v2.1.0) | [release-2.1](https://github.com/kubernetes-csi/external-snapshotter/tree/release-2.1) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | quay.io/k8scsi/csi-snapshotter:v2.1.0 | v1.17 | - | v1.17


https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v2.1.3

xing-yang · 2021-02-01T20:36:41Z

book/src/snapshot-controller.md

-[external-snapshotter v3.0.2](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v3.0.2) | [release-3.0](https://github.com/kubernetes-csi/external-snapshotter/tree/release-3.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/snapshot-controller:v3.0.2 | v1.17 | - | v1.17
-[external-snapshotter v2.1.0](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v2.1.0) | [release-2.1](https://github.com/kubernetes-csi/external-snapshotter/tree/release-2.1) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | quay.io/k8scsi/snapshot-controller:v2.1.0 | v1.17 | - | v1.17
+[external-snapshotter v4.0.0](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v4.0.0) | [release-4.0](https://github.com/kubernetes-csi/external-snapshotter/tree/release-4.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/snapshot-controller:v4.0.0 | v1.20 | - | v1.20
+[external-snapshotter v3.0.2 (beta)](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v3.0.2) | [release-3.0](https://github.com/kubernetes-csi/external-snapshotter/tree/release-3.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/snapshot-controller:v3.0.2 | v1.17 | - | v1.17


https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v3.0.3

xing-yang · 2021-02-01T20:36:57Z

book/src/snapshot-controller.md

-[external-snapshotter v2.1.0](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v2.1.0) | [release-2.1](https://github.com/kubernetes-csi/external-snapshotter/tree/release-2.1) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | quay.io/k8scsi/snapshot-controller:v2.1.0 | v1.17 | - | v1.17
+[external-snapshotter v4.0.0](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v4.0.0) | [release-4.0](https://github.com/kubernetes-csi/external-snapshotter/tree/release-4.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/snapshot-controller:v4.0.0 | v1.20 | - | v1.20
+[external-snapshotter v3.0.2 (beta)](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v3.0.2) | [release-3.0](https://github.com/kubernetes-csi/external-snapshotter/tree/release-3.0) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | k8s.gcr.io/sig-storage/snapshot-controller:v3.0.2 | v1.17 | - | v1.17
+[external-snapshotter v2.1.0 (beta)](https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v2.1.0) | [release-2.1](https://github.com/kubernetes-csi/external-snapshotter/tree/release-2.1) | [v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | - | quay.io/k8scsi/snapshot-controller:v2.1.0 | v1.17 | - | v1.17


https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v2.1.3

msau42 · 2021-02-17T03:13:35Z

Updated all the patch versions ptal

xing-yang · 2021-02-22T18:54:31Z

/lgtm
/approve

k8s-ci-robot · 2021-02-22T18:54:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42,xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2021

k8s-ci-robot requested review from lpabon and xing-yang January 14, 2021 03:45

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2021

msau42 commented Jan 14, 2021

View reviewed changes

k8s-ci-robot assigned xing-yang Jan 14, 2021

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 14, 2021

xing-yang reviewed Jan 14, 2021

View reviewed changes

pohly mentioned this pull request Jan 26, 2021

prow.sh: support building Kubernetes for a specific version kubernetes-csi/csi-release-tools#131

Merged

xing-yang reviewed Feb 1, 2021

View reviewed changes

msau42 force-pushed the update-versions branch from 2cc835f to 7fe8a62 Compare February 17, 2021 03:13

Update sidecars with latest versions

6042476

msau42 force-pushed the update-versions branch from 7fe8a62 to 6042476 Compare February 17, 2021 03:24

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2021

k8s-ci-robot merged commit 6758da5 into kubernetes-csi:master Feb 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update sidecars with latest versions #407

Update sidecars with latest versions #407

msau42 commented Jan 14, 2021

msau42 Jan 14, 2021

xing-yang Jan 14, 2021

msau42 commented Jan 14, 2021

xing-yang Jan 14, 2021

msau42 Jan 14, 2021

pohly Jan 15, 2021

msau42 Jan 16, 2021

pohly Jan 16, 2021 •

edited

Loading

msau42 Feb 1, 2021

pohly Feb 1, 2021

xing-yang Jan 14, 2021

xing-yang Jan 14, 2021

xing-yang Jan 14, 2021

xing-yang Feb 1, 2021

xing-yang Feb 1, 2021

xing-yang Feb 1, 2021

xing-yang Feb 1, 2021

xing-yang Feb 1, 2021

msau42 commented Feb 17, 2021

xing-yang commented Feb 22, 2021

k8s-ci-robot commented Feb 22, 2021

Update sidecars with latest versions #407

Update sidecars with latest versions #407

Conversation

msau42 commented Jan 14, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msau42 commented Jan 14, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pohly Jan 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msau42 commented Feb 17, 2021

xing-yang commented Feb 22, 2021

k8s-ci-robot commented Feb 22, 2021

pohly Jan 16, 2021 •

edited

Loading