Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NodeUnpublishVolume test for when the volume is missing #242

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Add NodeUnpublishVolume test for when the volume is missing #242

merged 1 commit into from
Feb 4, 2020

Conversation

timoreimann
Copy link
Contributor

@timoreimann timoreimann commented Dec 16, 2019 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds NodeUnpublishVolume test for when the volume is missing.

The spec mandates that such cases should return NOT_FOUND responses (reference).

The mock driver already implements the right behavior.

Does this PR introduce a user-facing change?:

Add NodeUnpublishVolume test for when the volume is missing

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 16, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 16, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @timoreimann!

It looks like this is your first PR to kubernetes-csi/csi-test 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-test has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @timoreimann. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 16, 2019
@timoreimann
Copy link
Contributor Author

/sig storag

@k8s-ci-robot
Copy link
Contributor

@timoreimann: The label(s) sig/storag cannot be applied, because the repository doesn't have them

In response to this:

/sig storag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timoreimann
Copy link
Contributor Author

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 16, 2019
timoreimann pushed a commit to digitalocean/csi-digitalocean that referenced this pull request Dec 16, 2019
Check volume exists during NodeUnpublishVolume
298995b 
The CSI spec mandates that we return NOT_FOUND if the volume isn't found
[1]. Otherwise, the calling sidecar will go into an endless retry loop
and block other operations on the volume.

A test for this case should go into github.com/kubernetes-csi/csi-test
but was yet missing. A PR has been submitted [2] and this change has
been tested against it. As soon as upstream approves, we can follow up
with another PR to incorporate an updated csi-sanity package.

[1]: https://github.com/container-storage-interface/spec/blob/4731db0e0bc53238b93850f43ab05d9355df0fd9/spec.md#nodeunpublishvolume-errors
[2]: kubernetes-csi/csi-test#242
timoreimann pushed a commit to digitalocean/csi-digitalocean that referenced this pull request Dec 16, 2019
Check volume exists during NodeUnpublishVolume
a3af9e8 
The CSI spec mandates that we return NOT_FOUND if the volume isn't found
[1]. Otherwise, the calling sidecar will go into an endless retry loop
and block other operations on the volume.

A test for this case should go into github.com/kubernetes-csi/csi-test
but was yet missing. A PR has been submitted [2] and this change has
been tested against it. As soon as upstream approves, we can follow up
with another PR to incorporate an updated csi-sanity package.

[1]: https://github.com/container-storage-interface/spec/blob/4731db0e0bc53238b93850f43ab05d9355df0fd9/spec.md#nodeunpublishvolume-errors
[2]: kubernetes-csi/csi-test#242
@timoreimann timoreimann mentioned this pull request Dec 16, 2019
Merged
timoreimann pushed a commit to digitalocean/csi-digitalocean that referenced this pull request Dec 16, 2019
Check volume exists during NodeUnpublishVolume
d009d46 
The CSI spec mandates that we return NOT_FOUND if the volume isn't found
[1]. Otherwise, the calling sidecar will go into an endless retry loop
and block other operations on the volume.

A test for this case should go into github.com/kubernetes-csi/csi-test
but was yet missing. A PR has been submitted [2] and this change has
been tested against it. As soon as upstream approves, we can follow up
with another PR to incorporate an updated csi-sanity package.

[1]: https://github.com/container-storage-interface/spec/blob/4731db0e0bc53238b93850f43ab05d9355df0fd9/spec.md#nodeunpublishvolume-errors
[2]: kubernetes-csi/csi-test#242
@pohly
Copy link
Contributor

pohly commented Jan 15, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2020
pohly
pohly requested changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/sanity/node.go
VolumeId: sc.Config.IDGen.GenerateUniqueValidVolumeID(),
TargetPath: sc.StagingPath,
})
Expect(err).To(HaveOccurred())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expect.To without some additional description leads to failure messages that cannot be understood without locating the source code. I know, most of the existing assertions are like that, but for new ones let's use Expect.To(..., "some description").

pkg/sanity/node.go
Expect(err).To(HaveOccurred())

serverError, ok := status.FromError(err)
Expect(ok).To(BeTrue())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2020
@jsafrane
Copy link
Contributor

jsafrane commented Feb 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, timoreimann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3ec4a00 into kubernetes-csi:master Feb 4, 2020
@timoreimann
Copy link
Contributor Author

@pohly sorry, I haven't had a chance to get back to this PR in time before it got merged. I'll address your comments in a follow-up PR.

@timoreimann timoreimann deleted the add-test-for-missing-volume-on-node-unpublish-volume-call branch April 16, 2020 19:39
This was referenced Apr 16, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly requested changes

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@pohly pohly

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timoreimann @k8s-ci-robot @pohly @jsafrane @maennchen