Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanity: volumes of zero capacity can be recreated #263

Closed
wants to merge 1 commit into from
Closed

sanity: volumes of zero capacity can be recreated #263

wants to merge 1 commit into from

Conversation

NicolasT
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
In general, when creating a volume of some requested capacity using
CreateVolume, then re-running the RPC with the same name but different
capacity request, this ought to fail with ALREADY_EXISTS (according to
the spec). However, when the reported capacity of a volume equals zero,
the volume capacity is unknown (again according to the spec). As such,
when issueing another CreateVolume call using the same name but a
different requested capacity, this should not necessarily fail, since a
volume whose size is (theoretically) unlimited is compatible with any
requested capacity.

This is in line with the spec:

Indicates that a volume corresponding to the specified volume name
already exists but is incompatible with the specified capacity_range,
volume_capabilities or parameters.

Given this, the relevant test is updated to skip when the capacity as
returned by the first CreateVolume call equals zero.

Which issue(s) this PR fixes:
Fixes #94

Special notes for your reviewer:
This is, of course, according to a particular reading of the CSI spec, which may be debatable. However, see #94 (comment) as to why the current test is problematic for some SPs.

Does this PR introduce a user-facing change?:

NONE

@NicolasT
sanity: volumes of zero capacity can be recreated
6f14812 
In general, when creating a volume of some requested capacity using
`CreateVolume`, then re-running the RPC with the same name but different
capacity request, this ought to fail with `ALREADY_EXISTS` (according to
the spec). However, when the reported capacity of a volume equals zero,
the volume capacity is unknown (again according to the spec). As such,
when issueing another `CreateVolume` call using the same name but a
different requested capacity, this should not necessarily fail, since a
volume whose size is (theoretically) unlimited is compatible with *any*
requested capacity.

This is in line with the spec:

> Indicates that a volume corresponding to the specified volume name
> already exists but is incompatible with the specified capacity_range,
> volume_capabilities or parameters.

Given this, the relevant test is updated to *skip* when the capacity as
returned by the first `CreateVolume` call equals zero.

See: kubernetes-csi#94
See: kubernetes-csi#94 (comment)
See: https://github.com/container-storage-interface/spec/blob/e129a75169c13bade7c7336afe21f259740ba679/spec.md#createvolume-errors
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NicolasT
To complete the pull request process, please assign lpabon
You can assign the PR to them by writing /assign @lpabon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from lpabon and saad-ali April 28, 2020 22:07
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 28, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @NicolasT. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2020
@NicolasT
Copy link
Contributor Author

/assign @lpabon

@NicolasT NicolasT mentioned this pull request Apr 30, 2020
Merged
@NicolasT
Copy link
Contributor Author

NicolasT commented May 5, 2020

For future reference: https://groups.google.com/d/msg/container-storage-interface-community/k5EAsH5LvMc/wn6xw1WwBgAJ

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 2, 2020
@k8s-ci-robot
Copy link
Contributor

@NicolasT: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpabon lpabon Awaiting requested review from lpabon

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@lpabon lpabon

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test fails if CapacityBytes is always 0
4 participants
@NicolasT @k8s-ci-robot @fejta-bot @lpabon