Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert NodePublishVolume behavior for single node single writer volumes #421

Closed
wants to merge 2 commits into from
Closed

Assert NodePublishVolume behavior for single node single writer volumes #421

wants to merge 2 commits into from

Conversation

chrishenzie
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds a test case that asserts SINGLE_NODE_SINGLE_WRITER volumes can only be published at one target path on a node.

Which issue(s) this PR fixes:
Fixes #420

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add node publish volume test for volume with SINGLE_NODE_SINGLE_WRITER access mode

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrishenzie
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval by writing /assign @xing-yang in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2022
@chrishenzie
Copy link
Contributor Author

/sig storage
/cc @msau42
/cc @jsafrane
/hold

Need to cut a release of the hostpath driver and update this PR to use that version.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Dec 19, 2022
jsafrane
jsafrane reviewed Jan 2, 2023
View reviewed changes
pkg/sanity/node.go Outdated Show resolved Hide resolved
@chrishenzie chrishenzie mentioned this pull request Jan 5, 2023
Closed
@jsafrane
Copy link
Contributor

jsafrane commented Jan 9, 2023

/retest
TestMyDriverWithCustomTargetPaths failed

@chrishenzie
Copy link
Contributor Author

I think this will continue failing until we've updated the hostpath driver version to v1.11, but we'll need to cut a release of it first

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2023
@chrishenzie
Copy link
Contributor Author

It looks like it failed because:

Go version for building the component: CSI_PROW_GO_VERSION_BUILD=1.18

...

# Building the hostpath driver
../../vendor/k8s.io/component-base/metrics/registry.go:35:29: undefined: atomic.Bool
note: module requires Go 1.19

Bumped the go version to 1.19 and testing now

@chrishenzie
Copy link
Contributor Author

Not seeing where the error is originating from
/retest

jsafrane
jsafrane reviewed Jan 31, 2023
View reviewed changes
release-tools/prow.sh Outdated Show resolved Hide resolved
@jsafrane
Copy link
Contributor

jsafrane commented Feb 1, 2023

/retest

@jsafrane
Copy link
Contributor

jsafrane commented Feb 1, 2023

New release-tools, new errors.

s: "target path creation command /home/prow/go/pkg/csiprow.LB7s91MBEk/mkdir_in_pod.sh failed: exit status 1",

I did not dig further

@chrishenzie
Helper functions for managing volumes with specific access modes
ed1324b
@chrishenzie
Assert NodePublishVolume behavior for single node single writer volumes
89676a6 
Ensure that a single node single writer volume cannot be mounted at two
different target paths on the same node.

See the second table in the NodePublishVolume section of the CSI spec
for more details:
https://github.com/container-storage-interface/spec/blob/v1.7.0/spec.md#nodepublishvolume
@k8s-ci-robot
Copy link
Contributor

@chrishenzie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-csi-test 89676a6 link true /test pull-kubernetes-csi-csi-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2023
@chrishenzie
Copy link
Contributor Author

/remove-lifecycle stale

I have a partially implemented test, just needs debugging

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 18, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@humblec humblec Awaiting requested review from humblec

@j-griffith j-griffith Awaiting requested review from j-griffith

@msau42 msau42 Awaiting requested review from msau42

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assert NodePublishVolume behavior for single node single writer volumes
4 participants
@chrishenzie @k8s-ci-robot @jsafrane @k8s-triage-robot