Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test ListSnapshots [Controller Server] should return empty when the specify source volume id is not exist #101

Closed
saad-ali opened this issue Aug 8, 2018 · 1 comment

Comments

@saad-ali
Copy link
Member

saad-ali commented Aug 8, 2018

The following test fails in travis randomly:

•••••••••••••••••[32m••••••••••••••••••••••••••STEP: connecting to CSI driver
------------------------------
• Failure in Spec Setup (BeforeEach) [60.002 seconds]
ListSnapshots [Controller Server]
/home/travis/gopath/src/github.com/kubernetes-csi/csi-test/pkg/sanity/tests.go:44
  should return empty when the specify source volume id is not exist [BeforeEach]
  /home/travis/gopath/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:1195
  Expected error:
      <*errors.errorString | 0xc420327130>: {
          s: "Connection timed out",
      }
      Connection timed out
  not to have occurred
  /home/travis/gopath/src/github.com/kubernetes-csi/csi-test/pkg/sanity/sanity.go:97
------------------------------
••••••••••••••

@pohly
Copy link
Contributor

pohly commented Aug 30, 2018

Looks like the issue that was reported by @darkowlzz in PR #97 and PR #98.

It's not specific to csi-test: the sidecar containers and kubelet can also run into intermittent connection problems. IMHO this needs further discussion and a consistent approach for retrying either the connection attempt in the custom dialer for Unix domain sockets or the gRPC request (as in PR #97). This is getting complicated enough that we'll probably want to have the code in a common package, which would need to be created first.

In the meantime I'll fix PR #98 so that it also works when embedding the sanity test in a large Ginkgo suite.

lpabon pushed a commit to lpabon/csi-test that referenced this issue Nov 20, 2018
Connecting once per test made testing flaky. We
could fix this with retries
(kubernetes-csi#97) but that
requires more discussion, so instead we just connect once per
process instead of once per test case. This was also said to be
faster (kubernetes-csi#98).

Fixes: kubernetes-csi#101
suneeth51 pushed a commit to suneeth51/csi-test that referenced this issue Sep 11, 2019
Connecting once per test made testing flaky. We
could fix this with retries
(kubernetes-csi#97) but that
requires more discussion, so instead we just connect once per
process instead of once per test case. This was also said to be
faster (kubernetes-csi#98).

Fixes: kubernetes-csi#101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants