Update snapshot CRD version #111

xing-yang · 2020-11-12T14:02:18Z

No description provided.

xing-yang · 2020-11-12T16:07:16Z

/release-note-none

xing-yang · 2020-11-12T18:13:32Z

The following CI jobs have passed on this PR: kubernetes-csi/csi-driver-host-path#221

pull-kubernetes-csi-csi-driver-host-path-alpha-1-19-on-kubernetes-master
pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-master
pull-kubernetes-csi-csi-driver-host-path-1-18-on-kubernetes-master
pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-master
pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-1-17
pull-kubernetes-csi-csi-driver-host-path-1-18-on-kubernetes-1-18
pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-1-19

Note: unit test will not pass because I modified release-tools manually.

xing-yang · 2020-11-12T18:13:42Z

/assign @pohly

xing-yang · 2020-11-12T18:32:22Z

/assign @msau42

xing-yang · 2020-11-12T18:32:31Z

/assign @jsafrane

msau42 · 2020-11-12T19:06:01Z

prow.sh

+	if [ "${CSI_PROW_KUBERNETES_VERSION}" = "latest" ] || [ "${CSI_PROW_DRIVER_CANARY}" == "canary" ]; then
+		echo "master"
+	else
+		echo "v3.0.0"


should this be the latest patch?

Longer term, it would be good to find a way that doesn't require updating release-tools after every release.

Updated to v3.0.2

I proposed this logic here based on the observation that the hard-coded v3.0.0 was wrong for some jobs.

What I hadn't considered is that whether it would make sense to move this setting entirely into the Prow jobs. I think it actually does make sense, because it's at the same level as "let's run with this version of Kubernetes" and the API for it is fairly stable (the assumption is that also future releases will deploy via four URLs).

So the same logic can also go into https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-csi/gen-jobs.sh such that the Prow job always sets CSI_PROW_KUBERNETES_VERSION, including the case where we currently use v3.0.0.

That opens the door for adding more test jobs for other combinations, like external-snapshotter v4.0.0 with controller from v3.0.0.

kubernetes/test-infra#19939 is a PR which bumps the version through the Prow job configs.

msau42 · 2020-11-12T19:12:41Z

/lgtm
/approve

k8s-ci-robot · 2020-11-12T19:12:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

prow.sh

pohly · 2020-11-12T19:06:34Z

prow.sh

@@ -330,7 +330,14 @@ configvar CSI_PROW_E2E_ALPHA_GATES_LATEST 'GenericEphemeralVolume=true,CSIStorag
 configvar CSI_PROW_E2E_ALPHA_GATES "$(get_versioned_variable CSI_PROW_E2E_ALPHA_GATES "${csi_prow_kubernetes_version_suffix}")" "alpha E2E feature gates"

 # Which external-snapshotter tag to use for the snapshotter CRD and snapshot-controller deployment
-configvar CSI_SNAPSHOTTER_VERSION 'v3.0.0' "external-snapshotter version tag"
+default_csi_snapshotter_version () {
+	if [ "${CSI_PROW_KUBERNETES_VERSION}" = "latest" ] || [ "${CSI_PROW_DRIVER_CANARY}" == "canary" ]; then


== is an unnecessary bashism

Fixed here: #112

pohly · 2020-11-12T19:16:12Z

prow.sh

+	if [ "${CSI_PROW_KUBERNETES_VERSION}" = "latest" ] || [ "${CSI_PROW_DRIVER_CANARY}" == "canary" ]; then
+		echo "master"
+	else
+		echo "v3.0.0"


I proposed this logic here based on the observation that the hard-coded v3.0.0 was wrong for some jobs.

What I hadn't considered is that whether it would make sense to move this setting entirely into the Prow jobs. I think it actually does make sense, because it's at the same level as "let's run with this version of Kubernetes" and the API for it is fairly stable (the assumption is that also future releases will deploy via four URLs).

So the same logic can also go into https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-csi/gen-jobs.sh such that the Prow job always sets CSI_PROW_KUBERNETES_VERSION, including the case where we currently use v3.0.0.

That opens the door for adding more test jobs for other combinations, like external-snapshotter v4.0.0 with controller from v3.0.0.

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 12, 2020

k8s-ci-robot requested review from msau42 and pohly November 12, 2020 14:02

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2020

xing-yang force-pushed the update_snapshot_v1_rc branch from 36abc25 to 3ee045d Compare November 12, 2020 16:06

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2020

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 12, 2020

xing-yang force-pushed the update_snapshot_v1_rc branch from 3ee045d to 0901bbe Compare November 12, 2020 17:27

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2020

xing-yang changed the title ~~WIP: Update snapshot CRD version~~ Update snapshot CRD version Nov 12, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2020

xing-yang force-pushed the update_snapshot_v1_rc branch from 0901bbe to f6ab4b9 Compare November 12, 2020 18:12

k8s-ci-robot assigned pohly Nov 12, 2020

k8s-ci-robot assigned msau42 Nov 12, 2020

k8s-ci-robot assigned jsafrane Nov 12, 2020

msau42 reviewed Nov 12, 2020

View reviewed changes

Update snapshot CRD version

57718f8

xing-yang force-pushed the update_snapshot_v1_rc branch from f6ab4b9 to 57718f8 Compare November 12, 2020 19:11

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020

k8s-ci-robot merged commit d437673 into kubernetes-csi:master Nov 12, 2020

pohly reviewed Nov 12, 2020

View reviewed changes

pohly mentioned this pull request May 5, 2021

release-2.0: update release-tools kubernetes-csi/livenessprobe#113

Closed

pohly mentioned this pull request Jul 6, 2021

release-2.0: update release-tools kubernetes-csi/livenessprobe#119

Closed

pohly mentioned this pull request Aug 2, 2021

master: update release-tools kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#812

Merged

pohly mentioned this pull request Nov 30, 2021

master: update release-tools kubernetes-sigs/gluster-file-external-provisioner#4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update snapshot CRD version #111

Update snapshot CRD version #111

xing-yang commented Nov 12, 2020

xing-yang commented Nov 12, 2020

xing-yang commented Nov 12, 2020 •

edited

Loading

xing-yang commented Nov 12, 2020

xing-yang commented Nov 12, 2020

xing-yang commented Nov 12, 2020

msau42 Nov 12, 2020

xing-yang Nov 12, 2020

xing-yang Nov 12, 2020

pohly Nov 12, 2020

pohly Nov 13, 2020

msau42 commented Nov 12, 2020

k8s-ci-robot commented Nov 12, 2020

pohly Nov 12, 2020

xing-yang Nov 12, 2020

pohly Nov 12, 2020

Update snapshot CRD version #111

Update snapshot CRD version #111

Conversation

xing-yang commented Nov 12, 2020

xing-yang commented Nov 12, 2020

xing-yang commented Nov 12, 2020 • edited Loading

xing-yang commented Nov 12, 2020

xing-yang commented Nov 12, 2020

xing-yang commented Nov 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msau42 commented Nov 12, 2020

k8s-ci-robot commented Nov 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xing-yang commented Nov 12, 2020 •

edited

Loading