Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Filesystem API from v1 to v2alpha1 #187

Merged
merged 1 commit into from
Jan 8, 2022
Merged

Bump Filesystem API from v1 to v2alpha1 #187

merged 1 commit into from
Jan 8, 2022

Conversation

mauriciopoppe
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:
Bumps the v1 filesystem API to v2alpha1, we're planning on adding a new v2alpha1 API that removes the contents of a directory, the files were generated with this script:

API_GROUP=filesystem OLD_API_VERSION=v1 NEW_API_VERSION=v2alpha1 scripts/bump-version.sh

Does this PR introduce a user-facing change?:

New API version v2alpha1 for the Filesystem API Group.

/cc @jingxu97 @ddebroy

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 7, 2022
@jingxu97
Copy link
Contributor

jingxu97 commented Jan 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2022
@mauriciopoppe mauriciopoppe mentioned this pull request Jan 7, 2022
Merged
@ddebroy
Copy link
Contributor

ddebroy commented Jan 8, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddebroy, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit e2ace04 into kubernetes-csi:master Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy Awaiting requested review from ddebroy

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mauriciopoppe @jingxu97 @ddebroy @k8s-ci-robot