You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is the feature and why do you need it:
The client is very unfriendly to use in its current state. Many function arguments are only specified in the docstrings, with the function signature simply containing **kwargs. The function bodies often use "locals()" instead of the params themselves which is very poor practice in general. most egregiously, the client makes no distinction whatsoever between required and optional attributes. This means that any codebase needs to implement this logic itself.
Describe the solution you'd like to see:
Use proper typehints and fully qualify function signatures where possible.
Do not use locals() unless it's actually necessary.
Validate that required attributes are present in a response and explicitly annotate optional attributes as Optional
The text was updated successfully, but these errors were encountered:
What is the feature and why do you need it:
The client is very unfriendly to use in its current state. Many function arguments are only specified in the docstrings, with the function signature simply containing
**kwargs
. The function bodies often use "locals()" instead of the params themselves which is very poor practice in general. most egregiously, the client makes no distinction whatsoever between required and optional attributes. This means that any codebase needs to implement this logic itself.Describe the solution you'd like to see:
Optional
The text was updated successfully, but these errors were encountered: