Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly annotate functions #2267

Open
Bladieblah opened this issue Aug 20, 2024 · 2 comments
Open

Properly annotate functions #2267

Bladieblah opened this issue Aug 20, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Bladieblah
Copy link

Bladieblah commented Aug 20, 2024

What is the feature and why do you need it:
The client is very unfriendly to use in its current state. Many function arguments are only specified in the docstrings, with the function signature simply containing **kwargs. The function bodies often use "locals()" instead of the params themselves which is very poor practice in general. most egregiously, the client makes no distinction whatsoever between required and optional attributes. This means that any codebase needs to implement this logic itself.

Describe the solution you'd like to see:

  • Use proper typehints and fully qualify function signatures where possible.
  • Do not use locals() unless it's actually necessary.
  • Validate that required attributes are present in a response and explicitly annotate optional attributes as Optional
@Bladieblah Bladieblah added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 20, 2024
@roycaihw
Copy link
Member

The majority of this client is generated based on openapi-generator (https://github.com/OpenAPITools/openapi-generator). Could you file feature request to the upstream generator?

@haskjold
Copy link

haskjold commented Sep 3, 2024

The majority of this client is generated based on openapi-generator (https://github.com/OpenAPITools/openapi-generator). Could you file feature request to the upstream generator?

How does that help when this client seems to be stuck on an ancient version of the upstream generator?

Ref: https://github.com/kubernetes-client/python/blob/master/scripts/update-client.sh#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants