Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2170: Add unit and integration tests for model and dataset initializers #2305

Closed
andreyvelich opened this issue Oct 23, 2024 · 5 comments · Fixed by #2323
Closed

KEP-2170: Add unit and integration tests for model and dataset initializers #2305

andreyvelich opened this issue Oct 23, 2024 · 5 comments · Fixed by #2323
Assignees
@seanlaii
Labels
kind/feature

Comments

@andreyvelich
Copy link
Member

andreyvelich commented Oct 23, 2024 •
edited
Loading

What you would like to be added?

We should add the unit tests and integration tests for dataset and model initializers after this PR: #2303

Love this feature?

Give it a 👍 We prioritize the features with most 👍
@varshaprasad96 varshaprasad96 mentioned this issue Oct 24, 2024
Merged
@seanlaii
Copy link
Contributor

Hi, could I take this one?

@tenzen-y
Copy link
Member

Hi, could I take this one?

Feel free to take this issue with /assign comment.

@seanlaii
Copy link
Contributor

/assign

@seanlaii seanlaii mentioned this issue Nov 9, 2024
Merged
1 task
@seanlaii
Copy link
Contributor

Could we rename this ticket to Add unit and Integration tests ...? Thank you!

@seanlaii
Copy link
Contributor

Hi @andreyvelich , should we rename this issue by replacing e2e with integration?

@andreyvelich andreyvelich changed the title KEP-2170: Add unit and E2E tests for model and dataset initializers KEP-2170: Add unit and integration tests for model and dataset initializers Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanlaii seanlaii

Labels
kind/feature
Projects
KEP-2170: Kubeflow Training V2 API
Status: Done
Milestone
No milestone
3 participants
@seanlaii @andreyvelich @tenzen-y