-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Code style enforcement #2442
Comments
/area sdk |
/area testing |
I would love to have mypy included too. |
Sounds good. However it seems like before we enforce mypy we need some additional works to make sure we can pass its tests |
FYI, tracker issue for frontend part is #2406 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
As discussed offline, currently KFP does not adopt a consistent coding style on its Python side. This is not the best practice.
Here we propose to use yapf to help contributors to enforce Google python coding style. I will send out a PR for the yapf configuration. The default configuration does not work very well :(
Also, I propose to use pylint to check the coding style in Travis CI.
[Update 10/21] Since yapf does do much to docstring, docformatter is recommended to auto-lint the docstring if a contributor found it hard to pass pylint checks.
The text was updated successfully, but these errors were encountered: