Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support S3 virtual hosted style #10814

Closed
sanchesoon opened this issue May 9, 2024 · 7 comments · Fixed by #11246
Closed

[feature] Support S3 virtual hosted style #10814

sanchesoon opened this issue May 9, 2024 · 7 comments · Fixed by #11246

Comments

@sanchesoon
Copy link

Feature Area

/area backend

What feature would you like to see?

To be able use Virtual Host Style S3 protocol we should provide configuration option. Because "by default, the S3 client will use virtual hosted bucket addressing when possible." According aws-sdk-go documentation.

What is the use case or pain point?

Ability to switch between Virtual Host and Path Style

Is there a workaround currently?

There is no work round for this. Because this is hardcoded https://github.com/kubeflow/pipelines/blob/master/backend/src/v2/objectstore/object_store.go#L260


Love this idea? Give it a 👍.

@HumairAK
Copy link
Collaborator

/assign @HumairAK

@thesuperzapper
Copy link
Member

@sanchesoon what additional benefit would this give us?

I am pretty sure it would take a lot of work, which would be better spent on other problems which actually affect the user experience.

@sanchesoon
Copy link
Author

@thesuperzapper It give us ability to use Virtual Host style. Not sure if here a lot work, should be just additional parameter to pass launcher (but I never did PR here)
BTW this was fixed in argo workflow https://github.com/argoproj/pkg/pull/368/files

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jul 13, 2024
@HumairAK
Copy link
Collaborator

/remove-lifecycle stale

@google-oss-prow google-oss-prow bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jul 14, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 13, 2024
@HumairAK
Copy link
Collaborator

/remove-lifecycle stale

@google-oss-prow google-oss-prow bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants