Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubeflow/pipelines
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 88df99e22a1fcdaaf3c4c001239381ee8e922188
Choose a base ref
..
head repository: kubeflow/pipelines
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 12331b0c370978fd7ddb79b3896e8169be7d1878
Choose a head ref
Showing with 6 additions and 5 deletions.
  1. +6 −5 backend/src/agent/persistence/worker/persistence_worker_test.go
11 changes: 6 additions & 5 deletions backend/src/agent/persistence/worker/persistence_worker_test.go
Original file line number Diff line number Diff line change
@@ -22,6 +22,7 @@ import (
client "github.com/kubeflow/pipelines/backend/src/agent/persistence/client"
"github.com/kubeflow/pipelines/backend/src/common/util"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
"k8s.io/client-go/tools/cache"
@@ -74,7 +75,7 @@ func TestPersistenceWorker_Success(t *testing.T) {
eventHandler,
false,
saver)
assert.NoError(t, err)
require.NoError(t, err)

// Test
eventHandler.handler.OnAdd(workflow, true)
@@ -105,7 +106,7 @@ func TestPersistenceWorker_NotFoundError(t *testing.T) {
eventHandler,
false,
saver)
assert.NoError(t, err)
require.NoError(t, err)

// Test
eventHandler.handler.OnAdd(workflow, true)
@@ -137,7 +138,7 @@ func TestPersistenceWorker_GetWorklowError(t *testing.T) {
eventHandler,
false,
saver)
assert.NoError(t, err)
require.NoError(t, err)

// Test
eventHandler.handler.OnAdd(workflow, true)
@@ -172,7 +173,7 @@ func TestPersistenceWorker_ReportWorkflowRetryableError(t *testing.T) {
eventHandler,
false,
saver)
assert.NoError(t, err)
require.NoError(t, err)

// Test
eventHandler.handler.OnAdd(workflow, true)
@@ -206,7 +207,7 @@ func TestPersistenceWorker_ReportWorkflowNonRetryableError(t *testing.T) {
eventHandler,
false,
saver)
assert.NoError(t, err)
require.NoError(t, err)

// Test
eventHandler.handler.OnAdd(workflow, true)