From de0747ec8b9a4d4a412457004b3bbac2cea2e6a4 Mon Sep 17 00:00:00 2001 From: "Yuan (Bob) Gong" Date: Mon, 27 Apr 2020 15:13:29 +0800 Subject: [PATCH] [Viewer] Service needs port name for istio (#3619) --- backend/src/crd/controller/viewer/reconciler/reconciler.go | 1 + backend/src/crd/controller/viewer/reconciler/reconciler_test.go | 1 + 2 files changed, 2 insertions(+) diff --git a/backend/src/crd/controller/viewer/reconciler/reconciler.go b/backend/src/crd/controller/viewer/reconciler/reconciler.go index ca1ad21b961..63f6777b6b6 100644 --- a/backend/src/crd/controller/viewer/reconciler/reconciler.go +++ b/backend/src/crd/controller/viewer/reconciler/reconciler.go @@ -260,6 +260,7 @@ func serviceFrom(v *viewerV1beta1.Viewer, deploymentName string) *corev1.Service }, Ports: []corev1.ServicePort{ corev1.ServicePort{ + Name: "http", Protocol: corev1.ProtocolTCP, Port: 80, TargetPort: intstr.IntOrString{IntVal: viewerTargetPort}}, diff --git a/backend/src/crd/controller/viewer/reconciler/reconciler_test.go b/backend/src/crd/controller/viewer/reconciler/reconciler_test.go index 47c6b807658..b303ec59925 100644 --- a/backend/src/crd/controller/viewer/reconciler/reconciler_test.go +++ b/backend/src/crd/controller/viewer/reconciler/reconciler_test.go @@ -359,6 +359,7 @@ func TestReconcile_EachViewerCreatesAService(t *testing.T) { }}, Spec: corev1.ServiceSpec{ Ports: []corev1.ServicePort{corev1.ServicePort{ + Name: "http", Protocol: corev1.ProtocolTCP, Port: int32(80), TargetPort: intstr.IntOrString{IntVal: viewerTargetPort},