diff --git a/frontend/src/lib/RunUtils.ts b/frontend/src/lib/RunUtils.ts index 2f0bc7d1531..d64ba7720c3 100644 --- a/frontend/src/lib/RunUtils.ts +++ b/frontend/src/lib/RunUtils.ts @@ -28,6 +28,7 @@ import { } from '../apis/run'; import { logger } from './Utils'; import WorkflowParser from './WorkflowParser'; +import { ApiExperiment } from 'src/apis/experiment'; export interface MetricMetadata { count: number; @@ -117,7 +118,7 @@ function getAllExperimentReferences(run?: ApiRun | ApiJob): ApiResourceReference ); } -function getNamespaceReferenceName(run?: ApiRun | ApiJob): string | undefined { +function getNamespaceReferenceName(run?: ApiExperiment): string | undefined { // There should be only one namespace reference. const namespaceRef = run && diff --git a/frontend/src/pages/RunDetails.test.tsx b/frontend/src/pages/RunDetails.test.tsx index de8c8caa3e7..b5f619f8736 100644 --- a/frontend/src/pages/RunDetails.test.tsx +++ b/frontend/src/pages/RunDetails.test.tsx @@ -1021,14 +1021,9 @@ describe('RunDetails', () => { it("loads logs in run's namespace", async () => { testRun.pipeline_runtime!.workflow_manifest = JSON.stringify({ + metadata: { namespace: 'username' }, status: { nodes: { node1: { id: 'node1' } } }, }); - testRun.run!.resource_references = [ - { - key: { type: ApiResourceType.NAMESPACE, id: 'username' }, - relationship: ApiRelationship.OWNER, - }, - ]; tree = shallow(); await getRunSpy; await TestUtils.flushPromises(); diff --git a/frontend/src/pages/RunDetails.tsx b/frontend/src/pages/RunDetails.tsx index 145cbf7a9d2..58e77f03025 100644 --- a/frontend/src/pages/RunDetails.tsx +++ b/frontend/src/pages/RunDetails.tsx @@ -784,7 +784,7 @@ export class RunDetails extends Page { try { const logs = await Apis.getPodLogs( selectedNodeDetails.id, - RunUtils.getNamespaceReferenceName(this.state.runMetadata), + this.state.workflow?.metadata?.namespace, ); selectedNodeDetails.logs = logs; this.setStateSafe({