istio: document procedure that generated the manifests

[yanniszark]

Since Istio comes with many available options, it's important to document which were used during generation of the istio we use in manifests.

@krishnadurai can you provide more info on the procedure you followed for the istio 1.3.1 package?
What is the source?
What arguments were used in helm?

/cc @jlewi @kkasravi @apyrgio

[krishnadurai]

@yanniszark glad that you bring this up. I'll look to soon document how I generated the manifests. Overall, I used the helm charts being maintained at istio/istio.
Using kustomize converter - https://github.com/ContainerSolutions/helm-convert - I was able to get these manifests converted to Kustomize manifests and later had to combine resources together manually.

Here are the commands for helm conversion which I used:

helm convert --destination <destination> --name istio --namespace "\$(namespace)" install/kubernetes/helm/istio --values install/kubernetes/helm/istio/values-istio-sds-auth.yaml

helm convert --destination <destination> --name istio install/kubernetes/helm/istio-init  --values install/kubernetes/helm/istio-init/values.yaml

Refer PR: #413

[yanniszark]

@krishnadurai it would be great if we could write that down in a doc.
In addition, I think it's better to refrain from doing manual work, since we want to be able to try different options and easily view the diffs with git to see what has changed.

I'm also a bit sceptical about helm convert.
I'm worried that it could introduce bugs.

I believe it would be better to just store the yaml blob that helm outputs.
This way, diffs are easy and we don't risk bugs getting introduced in the helm<->kustomize conversion.
What do you think?

/cc @jlewi

[xaniasd]

please keep in mind that helm charts will be deprecated in the future (see here). recommended way is to dump the manifests with istioctl manifest generate

[sarahmaddox]

/cc @krishnadurai and @yanniszark

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

[issue-label-bot]

Issue-Label Bot is automatically applying the labels:

Label	Probability
area/kustomize	0.89

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.