-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate optional Knative Eventing components from common manifests #2685
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/lifecycle frozen |
@juliusvonkohout for this, Do I need to move knative folder to contrib folder? |
It introduces inconsistent conventions, so it should simply be commented out from the installation kustomization file such that it is not considered as required. |
Solved in #2788 |
Description:
There are certain components which get deployed alongside all the required core Kubeflow stack. One example is the
knative-eventing
which is installed together with theKNative
stack of services.Suggestion:
If this component is not required for Kubeflow inner workings, then my suggestion is to deprecate it from the
/common
folder. This install creates a lot of unnecessary deployments and resources on the cluster (which rarely get used for critical functionality).Deprecation Note:
In order to keep the integration and still allow users to continue installing it if needed, it can be added as separate integration to
/contrib
folder.If this introduce inconsistent conventions, then it could simply be commented out from the installation kustomization file such that it is not considered as required.
Any thoughts?
The text was updated successfully, but these errors were encountered: