Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExitHandler not triggered on pipeline run cancellation #506

Closed
rafalbigaj opened this issue Mar 18, 2021 · 1 comment · Fixed by #631
Closed

ExitHandler not triggered on pipeline run cancellation #506

rafalbigaj opened this issue Mar 18, 2021 · 1 comment · Fixed by #631

Comments

@rafalbigaj
Copy link
Contributor

/kind bug

What steps did you take and what happened:
When cancelling a pipeline run, operations added with ExitHandler are not triggered.

Operations added with ExitHandler are mapped to the Tekton final tasks (finally).
Tekton final tasks are skipped when Tekton PipelineRun is cancelled.

What did you expect to happen:
A graceful pipeline run cancellation should guarantee that operations added with ExitHandler are triggered on run stop.

Additional information:
Related Argo issue: argoproj/argo-workflows#3155

Environment:

  • Python Version (use python --version): 3.7
  • SDK Version: 0.7.0
  • Tekton Version (use tkn version): 0.22
  • Kubernetes Version (use kubectl version): 1.18
  • OS (e.g. from /etc/os-release):
@stale
Copy link

stale bot commented Jun 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants