Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support modifying checks cronjob spec.startingDeadlineSeconds on cronjob to prevent warnings. #814

Closed
AjayTripathy opened this issue Mar 11, 2021 · 4 comments · Fixed by #819
Labels
enhancement New feature or request

Comments

@AjayTripathy
Copy link
Contributor

On some clusters cronjobs may take extra time to start, let's support allowing users to config it.

Context:
https://stackoverflow.com/questions/51065538/what-does-kubernetes-cronjobs-startingdeadlineseconds-exactly-mean

@AjayTripathy AjayTripathy added the enhancement New feature or request label Mar 11, 2021
@AjayTripathy AjayTripathy changed the title Support modifying checks pod spec.startingDeadlineSeconds on cronjob to prevent warnings. Support modifying checks cronjob spec.startingDeadlineSeconds on cronjob to prevent warnings. Mar 11, 2021
@dwbrown2
Copy link
Contributor

I know we have plans to migrate check to core Go application. Should we do that instead?

@AjayTripathy
Copy link
Contributor Author

Yeah, we're fairly close on that. But this is a 1-liner, mainly filed issue to track.

@dwbrown2
Copy link
Contributor

@AjayTripathy who is the user that originally requested this and are you able to close the loop?

@AjayTripathy
Copy link
Contributor Author

Yes, I can close the loop here, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants