-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart values undocumented #745
Comments
Strong +1 from me. Let's get more documentation added here. |
First PR #753 is out. This initial PR adds additional comments for options that exist in values file. We will also pull in other commonly used values. Our subcharts have many flags, so I believe we want to find a balance on the right flags to pull in. We ideally want to focus on commonly used options. |
#757 added with more to come |
|
It's rarely used and therefore documented on the network-allocation docs page. |
Sparse documentation is not effective for using the chart. IMHO the chart README.md should contain all |
I actually disagree, @pierluigilenoci. If we include all config options, this file will be more than 3k lines long. That will be a bad user experience for most. My proposal is that we references our subcharts. For example, we can include this for Prometheus. For more Prometheus configuration options, reference: prometheus/values.yaml |
Obviously, it makes no sense to document the configuration options for the sub-charts, for that just refer to the official documentation of the sub-charts. I'm talking about the exclusive configurations of kubecost. For example:
To be able to understand how to configure these options I had to go through the templates of the chart. |
Glad we're in agreement on that!
I'm not aware of any other missing config options, are you? |
Marking as closed as I don't see any others right now we need documented. |
@dwbrown2
|
Also the new networkPolicy parameters are not documented:
|
What problem are you trying to solve?
There are many completely undocumented configuration possibilities within the chart.
To give some examples:
Describe the solution you'd like
I'll like to have all the options well documented in the chart README.md so you don't have to guess or go to the chart templates to understand how it works. I want to suggest improving the readability of the whole documentation.
The text was updated successfully, but these errors were encountered: