Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem with channel handling #15

Closed
nyrahul opened this issue Mar 8, 2022 · 1 comment
Closed

problem with channel handling #15

nyrahul opened this issue Mar 8, 2022 · 1 comment
Assignees
@daemon1024
Labels
bug Something isn't working

Comments

@nyrahul
Copy link
Contributor

nyrahul commented Mar 8, 2022

PR #14 introduced a fix for race-condition handling. However, the handling might not be fool-proof i.e.,we are spawning a go routine for every client in the Watch*() APIs.

Need to understand the best way of handling the channels.
@nyrahul nyrahul added the bug Something isn't working label Mar 8, 2022
@daemon1024 daemon1024 self-assigned this Mar 9, 2022
@daemon1024 daemon1024 mentioned this issue Mar 9, 2022
Merged
@nyrahul
Copy link
Contributor Author

nyrahul commented Mar 10, 2022

Fixed by #16 . Thanks @daemon1024

@nyrahul nyrahul closed this as completed Mar 10, 2022
@daemon1024 daemon1024 mentioned this issue Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daemon1024 daemon1024

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nyrahul @daemon1024