Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try out using axum instead of actix #6

Closed
clux opened this issue Oct 28, 2021 · 2 comments · Fixed by #7
Closed

Try out using axum instead of actix #6

clux opened this issue Oct 28, 2021 · 2 comments · Fixed by #7
Assignees
@shanesveller
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@clux
Copy link
Member

clux commented Oct 28, 2021

We already have one POC for actix (controller-rs) and nice to have one that builds quickly. From the discord:

shane: not sure if there's any appetite in this direction beyond myself, but I'm experimenting (relatively successfully) with converting the two example projects in kube-rs github org from actix-web to axum. cursory/anecdotal results are all nice drops in dependency tree count, binary size and build time. I figure since a while back kube started to depend on tower itself there's some nice synergy to this combo.

shane: anecdata for version-rs: number of crates built: ~350->193, release binary size: ~9.5MB -> 7.6MB, release build, time on my 2018 6-core MBP: 2min56sec -> 1min42sec

cc @shanesveller
@clux clux added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 28, 2021
@shanesveller
Copy link
Contributor

Happy to contribute this when I get a bit more time!

@clux
Copy link
Member Author

clux commented Oct 30, 2021

Thanks a lot! No rush on this, but it would be appreciated. Putting you on assigned so that I remember.

@clux clux moved this to Backlog in Kube Roadmap Oct 30, 2021
@clux clux moved this from Backlog to In Progress in Kube Roadmap Oct 31, 2021
@clux clux linked a pull request Nov 1, 2021 that will close this issue
Replace actix-web with axum #7
Merged
@clux clux mentioned this issue Nov 1, 2021
Open
@clux clux closed this as completed in #7 Nov 2, 2021
Repository owner moved this from In Progress to Done in Kube Roadmap Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanesveller shanesveller

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Kube Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace actix-web with axum
2 participants
@shanesveller @clux