Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.0] 더보기 도메인 구현 #77

Merged
merged 7 commits into from
Dec 29, 2023
Merged

[2.0.0] 더보기 도메인 구현 #77

merged 7 commits into from
Dec 29, 2023

Conversation

x-0o0
Copy link
Contributor

@x-0o0 x-0o0 commented Dec 27, 2023 •
edited
Loading

사용방법

import SettingsUI // UI 컴포넌트 제공
import SettingsFeatures // Reducer 제공
import ComposableArchirecture

SettingsApp( // SettingsUI
    store: Store( // SettingsFeatures
        initialState: SettingsAppFeature.State(),
        reducer: { SettingsAppFeature() }
    )
)

BPM

  • Caches 에 AppIcons 추가
  • SettingsFeature, SettingsUI 추가

UI

SettingsApp Destination.subscription Path.appIconSelector Path.openSourceList Destination.feedback
스크린샷 2023-12-29 오전 2 26 11 스크린샷 2023-12-29 오전 2 26 18 스크린샷 2023-12-29 오전 2 26 33 스크린샷 2023-12-29 오전 2 26 45 스크린샷 2023-12-29 오전 2 26 56

UX

Simulator Screen Recording - iPhone 15 Pro - 2023-11-30 at 11 53 14

@x-0o0 x-0o0 added the 더보기 더보기 기능 (피드백 포함) label Dec 27, 2023
@x-0o0 x-0o0 changed the title Feature/jaesung/more [2.0.0] 더보기 Dec 27, 2023
@x-0o0 x-0o0 linked an issue Dec 27, 2023 that may be closed by this pull request
[2.0.0] 더보기 도메인 구현 (TCA 기반) #69
Closed
@x-0o0 x-0o0 force-pushed the feature/jaesung/more branch from d42a7e7 to aac276c Compare December 27, 2023 16:04
@x-0o0 x-0o0 marked this pull request as ready for review December 28, 2023 17:23
@x-0o0
Copy link
Contributor Author

x-0o0 commented Dec 28, 2023

/쿠링 패키지 빌드하고 패키지 테스트

@github-actions GitHub Actions
Copy link

🔨 iOS 17.0.1 iPhone 15 Pro 에서 스위프트 패키지를 빌드합니다.

@github-actions GitHub Actions
Copy link

🔨 iOS 17 iPhone 15 Pro 에서 쿠링 패키지를 테스트 합니다.

@x-0o0 x-0o0 changed the title [2.0.0] 더보기 [2.0.0] 더보기 도메인 구현 Dec 28, 2023
@x-0o0 x-0o0 added v2 PBM Package Based Modularization (패키지 기반 모듈화) TCA labels Dec 28, 2023
@github-actions GitHub Actions
Copy link

✅ 패키지를 성공적으로 빌드했습니다.

@github-actions GitHub Actions
Copy link

✅ iOS17 에서 패키지를 성공적으로 테스트 했습니다.

lgvv
lgvv approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@lgvv lgvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

후후,,, 팔로업 날잡고 해야겠습니다

완전 최고👏

@x-0o0
Copy link
Contributor Author

x-0o0 commented Dec 29, 2023

/쿠링 머지

@github-actions github-actions bot added the automerge auto merge 를 수동으로 미리 활성화 하는 경우 라벨을 추가해줘야 합니다. "/쿠링 머지" 실행시 자동으로 추가. label Dec 29, 2023
@github-actions github-actions bot merged commit c94a7c6 into develop/2.0.0 Dec 29, 2023
@github-actions GitHub Actions
Copy link

🕊️ PR #77이 머지되었습니다.

@github-actions github-actions bot deleted the feature/jaesung/more branch December 29, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgvv lgvv lgvv approved these changes

Assignees

@x-0o0 x-0o0

@sunshiningsoo sunshiningsoo

Labels
automerge auto merge 를 수동으로 미리 활성화 하는 경우 라벨을 추가해줘야 합니다. "/쿠링 머지" 실행시 자동으로 추가. PBM Package Based Modularization (패키지 기반 모듈화) TCA v2 더보기 더보기 기능 (피드백 포함)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.0.0] 더보기 도메인 구현 (TCA 기반)
3 participants
@x-0o0 @lgvv @sunshiningsoo